Use AsyncHooksGetExecutionAsyncId(Context) API on Node 24 (#210)

szegedi · szegedi · commit 83008b7c6052 · 2025-06-26T12:11:51.000+02:00
diff --git a/bindings/profilers/wall.cc b/bindings/profilers/wall.cc
@@ -1062,8 +1062,13 @@ NAN_METHOD(WallProfiler::Dispose) {
 }
 
 double GetAsyncIdNoGC(v8::Isolate* isolate) {
-  return isolate->InContext() ? node::AsyncHooksGetExecutionAsyncId(isolate)
-                              : -1;
+#if NODE_MAJOR_VERSION >= 24
+  HandleScope scope(isolate);
+  auto context = isolate->GetEnteredOrMicrotaskContext();
+  return context.IsEmpty() ? -1 : node::AsyncHooksGetExecutionAsyncId(context);
+#else
+  return node::AsyncHooksGetExecutionAsyncId(isolate);
+#endif
 }
 
 double WallProfiler::GetAsyncId(v8::Isolate* isolate) {

Original file line number	Diff line number	Diff line change
`@@ -1062,8 +1062,13 @@ NAN_METHOD(WallProfiler::Dispose) {`
`1062`	`1062`	`}`
`1063`	`1063`
`1064`	`1064`	`double GetAsyncIdNoGC(v8::Isolate* isolate) {`
`1065`		`- return isolate->InContext() ? node::AsyncHooksGetExecutionAsyncId(isolate)`
`1066`		`- : -1;`
	`1065`	`+#if NODE_MAJOR_VERSION >= 24`
	`1066`	`+ HandleScope scope(isolate);`
	`1067`	`+ auto context = isolate->GetEnteredOrMicrotaskContext();`
	`1068`	`+ return context.IsEmpty() ? -1 : node::AsyncHooksGetExecutionAsyncId(context);`
	`1069`	`+#else`
	`1070`	`+ return node::AsyncHooksGetExecutionAsyncId(isolate);`
	`1071`	`+#endif`
`1067`	`1072`	`}`
`1068`	`1073`
`1069`	`1074`	`double WallProfiler::GetAsyncId(v8::Isolate* isolate) {`