Node 24 support (#207)

* Add support for Node 24. Remove support for Node 16.

* Fix for Node 24

---------

Co-authored-by: Attila Szegedi <attila.szegedi@datadoghq.com>

Author: nsavoire

.github/workflows/build.yml

@@ -10,7 +10,7 @@ jobs:
   asan:
     strategy:
       matrix:
-        version: [16, 18, 20, 22, 23]
+        version: [18, 20, 22, 24]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -23,7 +23,7 @@ jobs:
   valgrind:
     strategy:
       matrix:
-        version: [16, 18, 20, 22, 23]
+        version: [18, 20, 22, 24]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

.gitlab/benchmarks.yml

@@ -32,10 +32,11 @@ benchmarks:
     - ./steps/run-benchmarks.sh
   parallel:
     matrix:
-      - MAJOR_NODE_VERSION: 16
       - MAJOR_NODE_VERSION: 18
       - MAJOR_NODE_VERSION: 20
       - MAJOR_NODE_VERSION: 22
+      # TODO: Re-enable this once supports for Node 24 is merged on main
+      # - MAJOR_NODE_VERSION: 24
   artifacts:
     name: "reports"
     paths:

bindings/profilers/wall.cc

@@ -671,7 +671,7 @@ NAN_METHOD(WallProfiler::New) {
 
 NAN_METHOD(WallProfiler::Start) {
   WallProfiler* wallProfiler =
-      Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
+      Nan::ObjectWrap::Unwrap<WallProfiler>(info.This());
 
   if (info.Length() != 0) {
     return Nan::ThrowTypeError("Start must not have any arguments.");
@@ -766,7 +766,7 @@ NAN_METHOD(WallProfiler::Stop) {
   bool restart = info[0].As<Boolean>()->Value();
 
   WallProfiler* wallProfiler =
-      Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
+      Nan::ObjectWrap::Unwrap<WallProfiler>(info.This());
 
   v8::Local<v8::Value> profile;
   auto err = wallProfiler->StopImpl(restart, profile);
@@ -996,27 +996,27 @@ void WallProfiler::SetContext(Isolate* isolate, Local<Value> value) {
 }
 
 NAN_GETTER(WallProfiler::GetContext) {
-  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
+  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.This());
   info.GetReturnValue().Set(profiler->GetContext(info.GetIsolate()));
 }
 
 NAN_SETTER(WallProfiler::SetContext) {
-  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
+  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.This());
   profiler->SetContext(info.GetIsolate(), value);
 }
 
 NAN_GETTER(WallProfiler::SharedArrayGetter) {
-  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
+  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.This());
   info.GetReturnValue().Set(profiler->jsArray_.Get(v8::Isolate::GetCurrent()));
 }
 
 NAN_METHOD(WallProfiler::V8ProfilerStuckEventLoopDetected) {
-  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
+  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.This());
   info.GetReturnValue().Set(profiler->v8ProfilerStuckEventLoopDetected());
 }
 
 NAN_METHOD(WallProfiler::Dispose) {
-  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.Holder());
+  auto profiler = Nan::ObjectWrap::Unwrap<WallProfiler>(info.This());
   delete profiler;
 }
 

package.json

@@ -83,5 +83,7 @@
   },
   "engines": {
     "node": ">=16"
-  }
+  },
+  "//": "Temporary fix to make nan@2.22.2 work with Node 24",
+  "postinstall": "sed -i '' 's/^.* Holder() const.*//' ./node_modules/nan/nan_callbacks_12_inl.h"
 }