Added error logging to typosquatting

Author: strongHunter

guarddog/analyzer/metadata/go/typosquatting.py

@@ -1,10 +1,13 @@
 import json
+import logging
 import os
 from typing import Optional
 
 from guarddog.analyzer.metadata.typosquatting import TyposquatDetector
 from guarddog.utils.config import TOP_PACKAGES_CACHE_LOCATION
 
+log = logging.getLogger("guarddog")
+
 
 class GoTyposquatDetector(TyposquatDetector):
     """Detector for typosquatting attacks for go modules. Checks for distance one Levenshtein,
@@ -38,8 +41,8 @@ def _get_top_packages_local(self, path: str) -> list[dict]:
             with open(path, "r") as f:
                 result = json.load(f)
                 return result
-        except FileNotFoundError as e:
-            pass # TODO: log error
+        except FileNotFoundError:
+            log.error(f"File not found: {path}")
 
     def detect(
         self,

guarddog/analyzer/metadata/npm/typosquatting.py

@@ -1,4 +1,5 @@
 import json
+import logging
 import os
 from datetime import datetime, timedelta
 from typing import Optional
@@ -7,6 +8,8 @@
 from guarddog.utils.config import TOP_PACKAGES_CACHE_LOCATION
 import requests
 
+log = logging.getLogger("guarddog")
+
 
 class NPMTyposquatDetector(TyposquatDetector):
     """Detector for typosquatting attacks. Detects if a package name is a typosquat of one of the top 5000 packages.
@@ -56,8 +59,8 @@ def _get_top_packages_local(self, path: str) -> list[dict]:
             with open(path, "r") as f:
                 result = json.load(f)
                 return result
-        except FileNotFoundError as e:
-            pass # TODO: log error
+        except FileNotFoundError:
+            log.error(f"File not found: {path}")
 
     def _get_top_packages_network(self, url: tuple[str]) -> list[dict]:
         try:
@@ -68,10 +71,10 @@ def _get_top_packages_network(self, url: tuple[str]) -> list[dict]:
             result = list([i["name"] for i in response_data[0:8000]])
 
             return result
-        except json.JSONDecodeError as e:
-            pass # TODO: log error
+        except json.JSONDecodeError:
+            log.error(f"Couldn`t convert to json: \"{response.text}\"")
         except requests.exceptions.RequestException as e:
-            pass # TODO: log error
+            log.error(f"Network error: {e}")
 
     def detect(
         self,

guarddog/analyzer/metadata/pypi/typosquatting.py

@@ -78,8 +78,8 @@ def _get_top_packages_local(self, path: str) -> list[dict]:
             with open(path, "r") as f:
                 result = json.load(f)
                 return result
-        except FileNotFoundError as e:
-            pass # TODO: log error
+        except FileNotFoundError:
+            log.error(f"File not found: {path}")
 
     def _get_top_packages_network(self, url: tuple[str]) -> list[dict]:
         try:
@@ -90,10 +90,10 @@ def _get_top_packages_network(self, url: tuple[str]) -> list[dict]:
             result = response_data
 
             return result
-        except json.JSONDecodeError as e:
-            pass # TODO: log error
+        except json.JSONDecodeError:
+            log.error(f"Couldn`t convert to json: \"{response.text}\"")
         except requests.exceptions.RequestException as e:
-            pass # TODO: log error
+            log.error(f"Network error: {e}")
 
     def detect(self, package_info, path: Optional[str] = None, name: Optional[str] = None,
                version: Optional[str] = None) -> tuple[bool, Optional[str]]: