Skip to content

[BUG]: Missing traces from custom Concurrent::Promises #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesleyjellis opened this issue Apr 16, 2025 · 0 comments
Open

[BUG]: Missing traces from custom Concurrent::Promises #4589

wesleyjellis opened this issue Apr 16, 2025 · 0 comments
Labels
bug Involves a bug community Was opened by a community member

Comments

@wesleyjellis
Copy link

Tracer Version(s)

2.9.0

Ruby Version(s)

ruby 3.3.7 (2025-01-15 revision be31f993d7) +YJIT [x86_64-linux]

Relevent Library and Version(s)

No response

Bug Report

When you create your own Promise class/module, let's say to override the default executor, any traces / metrics that are generated inside promises (which are in their own threads) are lost. Example of this is in the concurrent-ruby docs: https://ruby-concurrency.github.io/concurrent-ruby/master/file.promises.out.html

I think this is because PromisesFuturePatch is only applied to Concurrent::Promises module here:

This is easy enough to work around by either applying the patch manually, or not making your own Concurrent::Promises

Reproduction Code

No response

Configuration Block

No response

Error Logs

No response

Operating System

No response

How does Datadog help you?

No response

@wesleyjellis wesleyjellis added bug Involves a bug community Was opened by a community member labels Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug community Was opened by a community member
Projects
None yet
Development

No branches or pull requests

1 participant