test: remove get-port usage in core tests and appsec (#6060)

rochdev · web-flow · commit ef608d6c4869 · 2025-07-09T07:29:36.000Z
* remove get-port usage in core tests and a few more

* remove get-port usage from appsec plugin tests

* remove explicit hostname from appsec express test

* remove explicit hostname from appsec request helper test

* make port explicit and add comment to explain why an arbitrary port is fine
diff --git a/packages/datadog-plugin-fetch/test/integration-test/client.spec.js b/packages/datadog-plugin-fetch/test/integration-test/client.spec.js
@@ -16,7 +16,7 @@ describe('esm', () => {
 
   before(async function () {
     this.timeout(50000)
-    sandbox = await createSandbox(['get-port'], false, [
+    sandbox = await createSandbox([], false, [
       './packages/datadog-plugin-fetch/test/integration-test/*'])
   })
 
diff --git a/packages/datadog-plugin-fetch/test/integration-test/server.mjs b/packages/datadog-plugin-fetch/test/integration-test/server.mjs
@@ -1,9 +1,7 @@
 import 'dd-trace/init.js'
-import getPort from 'get-port'
 
-const port = await getPort()
-
-global.fetch(`http://localhost:${port}/foo`)
+// An arbitrary port is used here as we just need a request even if it fails.
+global.fetch('http://localhost:55555/foo')
   .then((response) => {})
   .then((data) => {})
   .catch((err) => {})
diff --git a/packages/datadog-plugin-net/test/integration-test/client.spec.js b/packages/datadog-plugin-net/test/integration-test/client.spec.js
@@ -15,7 +15,7 @@ describe('esm', () => {
 
   before(async function () {
     this.timeout(20000)
-    sandbox = await createSandbox(['net', 'get-port'], false, [
+    sandbox = await createSandbox(['net'], false, [
       './packages/datadog-plugin-net/test/integration-test/*'])
   })
 
diff --git a/packages/datadog-plugin-net/test/integration-test/server.mjs b/packages/datadog-plugin-net/test/integration-test/server.mjs
@@ -1,10 +1,7 @@
 import 'dd-trace/init.js'
 import net from 'net'
-import getPort from 'get-port'
 
-const port = await getPort()
-
-const client = net.createConnection(port, () => {})
+const client = net.createConnection(0, () => {})
 
 client.on('data', (data) => {})
 
diff --git a/packages/dd-trace/test/appsec/attacker-fingerprinting.fastify.plugin.spec.js b/packages/dd-trace/test/appsec/attacker-fingerprinting.fastify.plugin.spec.js
@@ -2,7 +2,6 @@
 
 const Axios = require('axios')
 const { assert } = require('chai')
-const getPort = require('get-port')
 const path = require('path')
 
 const agent = require('../plugins/agent')
@@ -26,13 +25,12 @@ withVersions('fastify', 'fastify', fastifyVersion => {
         reply.send('DONE')
       })
 
-      getPort().then((port) => {
-        app.listen({ port }, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
-        server = app.server
+      app.listen({ port: 0 }, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
+      server = app.server
     })
 
     after(() => {
diff --git a/packages/dd-trace/test/appsec/index.express.plugin.spec.js b/packages/dd-trace/test/appsec/index.express.plugin.spec.js
@@ -2,7 +2,6 @@
 
 const Axios = require('axios')
 const { assert } = require('chai')
-const getPort = require('get-port')
 const path = require('path')
 const agent = require('../plugins/agent')
 const appsec = require('../../src/appsec')
@@ -46,11 +45,10 @@ withVersions('express', 'express', version => {
 
       app.param('callbackedParameter', paramCallbackSpy)
 
-      getPort().then((port) => {
-        server = app.listen(port, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
+      server = app.listen(0, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
     })
 
@@ -196,11 +194,10 @@ withVersions('express', 'express', version => {
         res.end('DONE')
       })
 
-      getPort().then((port) => {
-        server = app.listen(port, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
+      server = app.listen(0, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
     })
 
@@ -274,11 +271,10 @@ withVersions('express', 'express', version => {
         res.json({ jsonResKey: 'jsonResValue' })
       })
 
-      getPort().then((port) => {
-        server = app.listen(port, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
+      server = app.listen(0, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
     })
 
diff --git a/packages/dd-trace/test/appsec/index.fastify.plugin.spec.js b/packages/dd-trace/test/appsec/index.fastify.plugin.spec.js
@@ -2,7 +2,6 @@
 
 const Axios = require('axios')
 const { assert } = require('chai')
-const getPort = require('get-port')
 const path = require('path')
 const zlib = require('zlib')
 const fs = require('node:fs')
@@ -29,13 +28,12 @@ withVersions('fastify', 'fastify', '>=2', version => {
         reply.send('DONE')
       })
 
-      getPort().then((port) => {
-        app.listen({ port }, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
-        server = app.server
+      app.listen({ port: 0 }, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
+      server = app.server
     })
 
     after(() => {
@@ -95,13 +93,12 @@ withVersions('fastify', 'fastify', '>=2', version => {
         reply.send('DONE')
       })
 
-      getPort().then((port) => {
-        app.listen({ port }, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
-        server = app.server
+      app.listen({ port: 0 }, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
+      server = app.server
     })
 
     after(() => {
@@ -205,13 +202,12 @@ withVersions('fastify', 'fastify', '>=2', version => {
         reply.send('DONE')
       })
 
-      getPort().then((port) => {
-        app.listen({ port }, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
-        server = app.server
+      app.listen({ port: 0 }, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
+      server = app.server
     })
 
     after(() => {
@@ -295,13 +291,12 @@ withVersions('fastify', 'fastify', '>=2', version => {
         reply.send('DONE')
       })
 
-      getPort().then((port) => {
-        app.listen({ port }, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
-        server = app.server
+      app.listen({ port: 0 }, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
+      server = app.server
     })
 
     after(() => {
@@ -478,13 +473,12 @@ withVersions('fastify', 'fastify', '>=2', version => {
               reply.send('DONE')
             })
 
-            getPort().then((port) => {
-              app.listen({ port }, () => {
-                axios = Axios.create({ baseURL: `http://localhost:${port}` })
-                done()
-              })
-              server = app.server
-            }).catch(done)
+            app.listen({ port: 0 }, () => {
+              const port = server.address().port
+              axios = Axios.create({ baseURL: `http://localhost:${port}` })
+              done()
+            })
+            server = app.server
           })
 
           beforeEach(async () => {
@@ -577,13 +571,12 @@ describe('Api Security - Fastify', () => {
         reply.send(new Uint16Array(10))
       })
 
-      getPort().then((port) => {
-        app.listen({ port }, () => {
-          axios = Axios.create({ baseURL: `http://localhost:${port}` })
-          done()
-        })
-        server = app.server
+      app.listen({ port: 0 }, () => {
+        const port = server.address().port
+        axios = Axios.create({ baseURL: `http://localhost:${port}` })
+        done()
       })
+      server = app.server
     })
 
     after(() => {
diff --git a/packages/dd-trace/test/exporters/common/request.spec.js b/packages/dd-trace/test/exporters/common/request.spec.js
@@ -3,13 +3,12 @@
 require('../../setup/tap')
 
 const nock = require('nock')
-const getPort = require('get-port')
 const http = require('http')
 const zlib = require('zlib')
 
 const FormData = require('../../../src/exporters/common/form-data')
 
-const initHTTPServer = (port) => {
+const initHTTPServer = () => {
   return new Promise(resolve => {
     const sockets = []
     const requestListener = function (req, res) {
@@ -23,11 +22,13 @@ const initHTTPServer = (port) => {
 
     server.on('connection', socket => sockets.push(socket))
 
-    server.listen(port, () => {
-      resolve(() => {
+    server.listen(0, () => {
+      const shutdown = () => {
         sockets.forEach(socket => socket.end())
         server.close()
-      })
+      }
+      shutdown.port = server.address().port
+      resolve(shutdown)
     })
   })
 }
@@ -223,37 +224,33 @@ describe('request', function () {
   })
 
   it('should be able to send concurrent requests to different hosts', function (done) {
-    // TODO: try to simplify the setup here. I haven't been able to reproduce the
-    // concurrent socket issue using nock
-    Promise.all([getPort(), getPort()]).then(([port1, port2]) => {
-      Promise.all([initHTTPServer(port1), initHTTPServer(port2)]).then(([shutdownFirst, shutdownSecond]) => {
-        // this interval is blocking a socket for the other request
-        const intervalId = setInterval(() => {
-          request(Buffer.from(''), {
-            path: '/',
-            method: 'POST',
-            hostname: 'localhost',
-            protocol: 'http:',
-            port: port1
-          }, () => {})
-        }, 1000)
-
-        setTimeout(() => {
-          request(Buffer.from(''), {
-            path: '/',
-            method: 'POST',
-            hostname: 'localhost',
-            protocol: 'http:',
-            port: port2
-          }, (err, res) => {
-            expect(res).to.equal('OK')
-            shutdownFirst()
-            shutdownSecond()
-            clearInterval(intervalId)
-            done()
-          })
-        }, 2000)
-      })
+    Promise.all([initHTTPServer(), initHTTPServer()]).then(([shutdownFirst, shutdownSecond]) => {
+      // this interval is blocking a socket for the other request
+      const intervalId = setInterval(() => {
+        request(Buffer.from(''), {
+          path: '/',
+          method: 'POST',
+          hostname: 'localhost',
+          protocol: 'http:',
+          port: shutdownFirst.port
+        }, () => {})
+      }, 1000)
+
+      setTimeout(() => {
+        request(Buffer.from(''), {
+          path: '/',
+          method: 'POST',
+          hostname: 'localhost',
+          protocol: 'http:',
+          port: shutdownSecond.port
+        }, (err, res) => {
+          expect(res).to.equal('OK')
+          shutdownFirst()
+          shutdownSecond()
+          clearInterval(intervalId)
+          done()
+        })
+      }, 2000)
     })
   })
 
diff --git a/packages/dd-trace/test/flare.spec.js b/packages/dd-trace/test/flare.spec.js
@@ -3,7 +3,6 @@
 const Config = require('../src/config')
 const { channel } = require('dc-polyfill')
 const express = require('express')
-const getPort = require('get-port')
 const http = require('http')
 const upload = require('multer')()
 const proxyquire = require('proxyquire').noCallThru()
@@ -23,7 +22,7 @@ describe('Flare', () => {
   let socket
   let handler
 
-  const createServer = () => {
+  const createServer = (done) => {
     const app = express()
 
     app.post('/tracer_flare/v1', upload.any(), (req, res) => {
@@ -36,7 +35,10 @@ describe('Flare', () => {
       socket = socket_
     })
 
-    listener = server.listen(port)
+    listener = server.listen(0, '127.0.0.1', () => {
+      port = server.address().port
+      done()
+    })
   }
 
   beforeEach(() => {
@@ -49,12 +51,10 @@ describe('Flare', () => {
     flare = proxyquire('../src/flare', {
       '../startup-log': startupLog
     })
-
-    return getPort().then(port_ => {
-      port = port_
-    })
   })
 
+  beforeEach(createServer)
+
   beforeEach(() => {
     tracerConfig = new Config({
       url: `http://127.0.0.1:${port}`
@@ -65,8 +65,6 @@ describe('Flare', () => {
       hostname: 'myhostname',
       user_handle: 'user.name@datadoghq.com'
     }
-
-    createServer()
   })
 
   afterEach(done => {
diff --git a/packages/dd-trace/test/profiling/exporters/agent.spec.js b/packages/dd-trace/test/profiling/exporters/agent.spec.js
diff --git a/packages/dd-trace/test/setup/core.js b/packages/dd-trace/test/setup/core.js
