Skip to content

Commit ee3f034

Browse files
[test optimization] Fix playwright tests in v5 (#5944)
1 parent abdf73b commit ee3f034

File tree

1 file changed

+13
-4
lines changed
  • packages/dd-trace/src/plugins/util

1 file changed

+13
-4
lines changed

packages/dd-trace/src/plugins/util/test.js

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,10 @@ const MINIMUM_FRAMEWORK_VERSION_FOR_QUARANTINE = {
142142
const MINIMUM_FRAMEWORK_VERSION_FOR_DISABLE = {
143143
playwright: '>=1.38.0'
144144
}
145+
const MINIMUM_FRAMEWORK_VERSION_FOR_ATTEMPT_TO_FIX = {
146+
playwright: '>=1.38.0'
147+
}
148+
145149
const UNSUPPORTED_ATTEMPT_TO_FIX_FRAMEWORKS_PARALLEL_MODE = new Set(['mocha'])
146150
const NOT_SUPPORTED_GRANULARITY_IMPACTED_TESTS_FRAMEWORKS = new Set(['mocha', 'playwright', 'vitest'])
147151

@@ -932,7 +936,11 @@ function isDisableSupported (testFramework, frameworkVersion) {
932936
: true
933937
}
934938

935-
function isAttemptToFixSupported (testFramework, isParallel) {
939+
function isAttemptToFixSupported (testFramework, isParallel, frameworkVersion) {
940+
if (testFramework === 'playwright') {
941+
return satisfies(frameworkVersion, MINIMUM_FRAMEWORK_VERSION_FOR_ATTEMPT_TO_FIX[testFramework])
942+
}
943+
936944
return !(isParallel && UNSUPPORTED_ATTEMPT_TO_FIX_FRAMEWORKS_PARALLEL_MODE.has(testFramework))
937945
}
938946

@@ -954,9 +962,10 @@ function getLibraryCapabilitiesTags (testFramework, isParallel, frameworkVersion
954962
[DD_CAPABILITIES_TEST_MANAGEMENT_DISABLE]: isDisableSupported(testFramework, frameworkVersion)
955963
? '1'
956964
: undefined,
957-
[DD_CAPABILITIES_TEST_MANAGEMENT_ATTEMPT_TO_FIX]: isAttemptToFixSupported(testFramework, isParallel)
958-
? '4'
959-
: undefined
965+
[DD_CAPABILITIES_TEST_MANAGEMENT_ATTEMPT_TO_FIX]:
966+
isAttemptToFixSupported(testFramework, isParallel, frameworkVersion)
967+
? '4'
968+
: undefined
960969
}
961970
}
962971

0 commit comments

Comments
 (0)