[test-optimization] [SDTEST-1923] Fix Playwright tests in v5 (#5788)

Author: Mariovido

integration-tests/playwright/playwright.spec.js

@@ -1,6 +1,7 @@
 'use strict'
 
 const { exec, execSync } = require('child_process')
+const satisfies = require('semifies')
 
 const getPort = require('get-port')
 const { assert } = require('chai')
@@ -55,6 +56,12 @@ const NUM_RETRIES_EFD = 3
 const versions = [DD_MAJOR >= 6 ? '1.38.0' : '1.18.0', 'latest']
 
 versions.forEach((version) => {
+  // TODO: Remove this once we drop suppport for v5
+  const contextNewVersions = (...args) => {
+    if (satisfies(version, '>=1.38.0') || version === 'latest') {
+      context(...args)
+    }
+  }
   describe(`playwright@${version}`, () => {
     let sandbox, cwd, receiver, childProcess, webAppPort, webPortWithRedirect
 
@@ -282,7 +289,7 @@ versions.forEach((version) => {
       )
     })
 
-    context('early flake detection', () => {
+    contextNewVersions('early flake detection', () => {
       it('retries new tests', (done) => {
         receiver.setSettings({
           early_flake_detection: {
@@ -820,7 +827,7 @@ versions.forEach((version) => {
       })
     })
 
-    context('known tests without early flake detection', () => {
+    contextNewVersions('known tests without early flake detection', () => {
       it('detects new tests without retrying them', (done) => {
         receiver.setSettings({
           known_tests_enabled: true
@@ -914,7 +921,7 @@ versions.forEach((version) => {
       })
     })
 
-    context('test management', () => {
+    contextNewVersions('test management', () => {
       context('attempt to fix', () => {
         beforeEach(() => {
           receiver.setTestManagementTests({
@@ -1367,7 +1374,7 @@ versions.forEach((version) => {
       })
     })
 
-    context('active test span', () => {
+    contextNewVersions('active test span', () => {
       it('can grab the test span and add tags', (done) => {
         const receiverPromise = receiver
           .gatherPayloadsMaxTimeout(({ url }) => url === '/api/v2/citestcycle', (payloads) => {
@@ -1433,7 +1440,7 @@ versions.forEach((version) => {
       })
     })
 
-    context('correlation between tests and RUM sessions', () => {
+    contextNewVersions('correlation between tests and RUM sessions', () => {
       const getTestAssertions = ({ isRedirecting }) =>
         receiver
           .gatherPayloadsMaxTimeout(({ url }) => url === '/api/v2/citestcycle', (payloads) => {

packages/datadog-instrumentations/src/playwright.js

@@ -1,3 +1,5 @@
+const satisfies = require('semifies')
+
 const { addHook, channel, AsyncResource } = require('./helpers/instrument')
 const shimmer = require('../../datadog-shimmer')
 const {
@@ -54,6 +56,7 @@ let testManagementAttemptToFixRetries = 0
 let testManagementTests = {}
 const quarantinedOrDisabledTestsAttemptToFix = []
 let rootDir = ''
+const MINIMUM_SUPPORTED_VERSION_RANGE_EFD = '>=1.38.0' // TODO: remove this once we drop support for v5
 
 function getTestProperties (test) {
   const testName = getTestFullname(test)
@@ -524,7 +527,7 @@ function runnerHook (runnerExport, playwrightVersion) {
       log.error('Playwright session start error', e)
     }
 
-    if (isKnownTestsEnabled) {
+    if (isKnownTestsEnabled && satisfies(playwrightVersion, MINIMUM_SUPPORTED_VERSION_RANGE_EFD)) {
       try {
         const { err, knownTests: receivedKnownTests } = await getChannelPromise(knownTestsCh)
         if (!err) {
@@ -540,7 +543,7 @@ function runnerHook (runnerExport, playwrightVersion) {
       }
     }
 
-    if (isTestManagementTestsEnabled) {
+    if (isTestManagementTestsEnabled && satisfies(playwrightVersion, MINIMUM_SUPPORTED_VERSION_RANGE_EFD)) {
       try {
         const { err, testManagementTests: receivedTestManagementTests } = await getChannelPromise(testManagementTestsCh)
         if (!err) {
@@ -668,7 +671,7 @@ addHook({
   name: 'playwright',
   file: 'lib/runner/dispatcher.js',
   versions: ['>=1.38.0']
-}, (dispatcher, version) => dispatcherHookNew(dispatcher, dispatcherRunWrapperNew, version))
+}, (dispatcher) => dispatcherHookNew(dispatcher, dispatcherRunWrapperNew))
 
 addHook({
   name: 'playwright',