Add _dd.integration to spans to have a safe component tag (#5652)

* Add _dd.integration to spans to calculate internal stats

* Align integration name used in the telemetry to meta[component] where possible

* fix child process tests

* fix typos

* misc fixes to startSpan

* Add mysql tests

* fix next integration

* assert integration name tag during integration tests

* fix condition

* fix aws-sdk instrumentation and test checks

* lint

* Fix http2 integration name

* add integrationName to ciViz integrations

* add suggestions

* fix other tests

---------

Co-authored-by: William Conti <william.conti@datadoghq.com>

Author: amarziali

packages/datadog-plugin-amqp10/test/index.spec.js

@@ -90,6 +90,7 @@ describe('Plugin', () => {
                 expect(span.meta).to.have.property('amqp.link.role', 'sender')
                 expect(span.meta['amqp.link.name']).to.match(/^amq\.topic_[0-9a-f-]+$/)
                 expect(span.meta).to.have.property('component', 'amqp10')
+                expect(span.meta).to.have.property('_dd.integration', 'amqp10')
                 expect(span.metrics).to.have.property('network.destination.port', 5673)
                 expect(span.metrics).to.have.property('amqp.connection.port', 5673)
                 expect(span.metrics).to.have.property('amqp.link.handle', 1)

packages/datadog-plugin-amqplib/test/index.spec.js

@@ -77,6 +77,7 @@ describe('Plugin', () => {
                   expect(span.meta).to.have.property('span.kind', 'client')
                   expect(span.meta).to.have.property('out.host', 'localhost')
                   expect(span.meta).to.have.property('component', 'amqplib')
+                  expect(span.meta).to.have.property('_dd.integration', 'amqplib')
                   expect(span.metrics).to.have.property('network.destination.port', 5672)
                 }, 2)
                 .then(done)

packages/datadog-plugin-apollo/test/index.spec.js

@@ -151,6 +151,7 @@ describe('Plugin', () => {
               expect(traces[0][0].meta).to.not.have.property('graphql.source')
               expect(traces[0][0].meta).to.have.property('graphql.operation.type', 'query')
               expect(traces[0][0].meta).to.have.property('component', 'apollo.gateway')
+              expect(traces[0][0].meta).to.have.property('_dd.integration', 'apollo.gateway')
 
               expect(traces[0][1]).to.have.property('name', 'apollo.gateway.validate')
               expect(traces[0][1]).to.have.property('service', expectedSchema.server.serviceName)

packages/datadog-plugin-aws-sdk/src/base.js

@@ -56,7 +56,12 @@ class BaseAwsSdkPlugin extends ClientPlugin {
       }
       if (this.requestTags) this.requestTags.set(request, tags)
 
-      const span = this.tracer.startSpan(this.operationFromRequest(request), { childOf, tags })
+      const span = this.tracer.startSpan(this.operationFromRequest(request),
+        {
+          childOf,
+          tags,
+          integrationName: 'aws-sdk'
+        })
 
       analyticsSampler.sample(span, this.config.measured)
 

packages/datadog-plugin-aws-sdk/src/services/kinesis.js

@@ -38,7 +38,8 @@ class Kinesis extends BaseAwsSdkPlugin {
             tags: {
               ...this.requestTags.get(request),
               'span.kind': 'server'
-            }
+            },
+            integrationName: 'aws-sdk'
           }
           span = plugin.tracer.startSpan('aws.response', options)
           this.enter(span, store)

packages/datadog-plugin-aws-sdk/src/services/sqs.js

@@ -30,7 +30,8 @@ class Sqs extends BaseAwsSdkPlugin {
           tags: {
             ...this.requestTags.get(request),
             'span.kind': 'server'
-          }
+          },
+          integrationName: 'aws-sdk'
         }
         parsedMessageAttributes = contextExtraction.parsedAttributes
         span = this.tracer.startSpan('aws.response', options)

packages/datadog-plugin-child_process/test/index.spec.js

@@ -61,7 +61,7 @@ describe('Child process plugin', () => {
               'span.type': 'system',
               'cmd.exec': JSON.stringify(['ls', '-l'])
             },
-            integrationName: 'system',
+            integrationName: 'child_process',
             links: undefined
           }
         )
@@ -84,7 +84,7 @@ describe('Child process plugin', () => {
               'span.type': 'system',
               'cmd.shell': 'ls -l'
             },
-            integrationName: 'system',
+            integrationName: 'child_process',
             links: undefined
           }
         )
@@ -110,7 +110,7 @@ describe('Child process plugin', () => {
               'cmd.exec': JSON.stringify(['echo', arg, '']),
               'cmd.truncated': 'true'
             },
-            integrationName: 'system',
+            integrationName: 'child_process',
             links: undefined
           }
         )
@@ -136,7 +136,7 @@ describe('Child process plugin', () => {
               'cmd.shell': 'ls -l /h ',
               'cmd.truncated': 'true'
             },
-            integrationName: 'system',
+            integrationName: 'child_process',
             links: undefined
           }
         )
@@ -163,7 +163,7 @@ describe('Child process plugin', () => {
               'cmd.exec': JSON.stringify(['ls', '-l', '', '']),
               'cmd.truncated': 'true'
             },
-            integrationName: 'system',
+            integrationName: 'child_process',
             links: undefined
           }
         )
@@ -190,7 +190,7 @@ describe('Child process plugin', () => {
               'cmd.shell': 'ls -l /home -t',
               'cmd.truncated': 'true'
             },
-            integrationName: 'system',
+            integrationName: 'child_process',
             links: undefined
           }
         )

packages/datadog-plugin-connect/test/index.spec.js

@@ -59,6 +59,7 @@ describe('Plugin', () => {
                 expect(spans[0].meta).to.have.property('http.method', 'GET')
                 expect(spans[0].meta).to.have.property('http.status_code', '200')
                 expect(spans[0].meta).to.have.property('component', 'connect')
+                expect(spans[0].meta).to.have.property('_dd.integration', 'connect')
               })
               .then(done)
               .catch(done)

packages/datadog-plugin-couchbase/test/index.spec.js

@@ -85,6 +85,7 @@ describe('Plugin', () => {
                 expect(span.meta).to.have.property('span.kind', 'client')
                 expect(span.meta).to.have.property('couchbase.bucket.name', 'datadog-test')
                 expect(span.meta).to.have.property('component', 'couchbase')
+                expect(span.meta).to.have.property('_dd.integration', 'couchbase')
               })
               .then(done)
               .catch(done)

packages/datadog-plugin-cucumber/src/index.js

@@ -184,7 +184,8 @@ class CucumberPlugin extends CiPlugin {
           [COMPONENT]: this.constructor.id,
           ...this.testEnvironmentMetadata,
           ...testSuiteMetadata
-        }
+        },
+        integrationName: this.constructor.id
       })
       this.testSuiteSpanByPath[testSuitePath] = testSuiteSpan
 
@@ -295,7 +296,8 @@ class CucumberPlugin extends CiPlugin {
           [COMPONENT]: this.constructor.id,
           'cucumber.step': resource,
           [RESOURCE_NAME]: resource
-        }
+        },
+        integrationName: this.constructor.id
       })
       ctx.parentStore = store
       ctx.currentStore = { ...store, span }