Skip to content

Commit 9e3721c

Browse files
authored
[test-optimization] [SDTEST-2290] Remove Cucumber and Selenium tests (#6086)
1 parent fd626ea commit 9e3721c

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

.github/workflows/test-optimization.yml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,9 @@ jobs:
7575
integration-ci:
7676
strategy:
7777
matrix:
78+
# TODO: Add cucumber and selenium once cucumber+12 is fixed
7879
version: [oldest, latest]
79-
framework: [cucumber, selenium, jest, mocha]
80+
framework: [jest, mocha]
8081
runs-on: ubuntu-latest
8182
env:
8283
DD_SERVICE: dd-trace-js-integration-tests
@@ -160,13 +161,14 @@ jobs:
160161
env:
161162
NODE_OPTIONS: '-r ./ci/init'
162163

163-
plugin-cucumber:
164-
runs-on: ubuntu-latest
165-
env:
166-
PLUGINS: cucumber
167-
steps:
168-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
169-
- uses: ./.github/actions/plugins/test
164+
# TODO: Remove comment once cucumber+12 is fixed
165+
# plugin-cucumber:
166+
# runs-on: ubuntu-latest
167+
# env:
168+
# PLUGINS: cucumber
169+
# steps:
170+
# - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
171+
# - uses: ./.github/actions/plugins/test
170172

171173
# TODO: fix performance issues and test more Node versions
172174
plugin-cypress:

integration-tests/ci-visibility/automatic-log-submission.spec.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,11 @@ describe('test visibility automatic log submission', () => {
5959
name: 'jest',
6060
command: 'node ./node_modules/jest/bin/jest --config ./ci-visibility/automatic-log-submission/config-jest.js'
6161
},
62-
{
63-
name: 'cucumber',
64-
command: './node_modules/.bin/cucumber-js ci-visibility/automatic-log-submission-cucumber/*.feature'
65-
},
62+
// TODO: Uncomment once cucumber+12 is fixed
63+
// {
64+
// name: 'cucumber',
65+
// command: './node_modules/.bin/cucumber-js ci-visibility/automatic-log-submission-cucumber/*.feature'
66+
// },
6667
{
6768
name: 'playwright',
6869
command: './node_modules/.bin/playwright test -c playwright.config.js',

scripts/verify-ci-config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@ checkPlugins(path.join(__dirname, '..', '.github', 'workflows', 'test-optimizati
150150
.filter(file => fs.existsSync(path.join(__dirname, '..', 'packages', file, 'test')))
151151
.map(file => file.replace('datadog-plugin-', ''))
152152
for (const plugin of allPlugins) {
153-
if (!allTestedPlugins.has(plugin)) {
153+
// TODO: Remove check of cucumber once cucumber+12 is fixed
154+
if (!allTestedPlugins.has(plugin) && plugin !== 'cucumber') {
154155
pluginErrorMsg(plugin, 'ERROR', 'Plugin is tested but not in at least one GitHub workflow')
155156
}
156157
}

0 commit comments

Comments
 (0)