Skip to content

Commit 54316ae

Browse files
authored
[test-optimization] [SDTEST-1871] Fix Playwright bug when redirecting (#5594)
1 parent 6b38d1c commit 54316ae

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

packages/datadog-instrumentations/src/playwright.js

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -813,19 +813,25 @@ addHook({
813813

814814
const page = this
815815

816-
const isRumActive = await page.evaluate(() => {
817-
if (window.DD_RUM && window.DD_RUM.getInternalContext) {
818-
return !!window.DD_RUM.getInternalContext()
819-
} else {
820-
return false
821-
}
822-
})
816+
try {
817+
if (page) {
818+
const isRumActive = await page.evaluate(() => {
819+
if (window.DD_RUM && window.DD_RUM.getInternalContext) {
820+
return !!window.DD_RUM.getInternalContext()
821+
} else {
822+
return false
823+
}
824+
})
823825

824-
if (isRumActive) {
825-
testPageGotoCh.publish({
826-
isRumActive,
827-
page
828-
})
826+
if (isRumActive) {
827+
testPageGotoCh.publish({
828+
isRumActive,
829+
page
830+
})
831+
}
832+
}
833+
} catch (e) {
834+
// ignore errors such as redirects, context destroyed, etc
829835
}
830836

831837
return response

0 commit comments

Comments
 (0)