test: fix next test network error by removing get-port usage (#6051)

* fix appsec next test as well

* fix standalone mode

Author: rochdev

packages/datadog-plugin-next/test/index.spec.js

@@ -4,7 +4,6 @@
 
 const path = require('node:path')
 const axios = require('axios')
-const getPort = require('get-port')
 const { execSync, spawn } = require('node:child_process')
 const { withNamingSchema, withVersions } = require('../../dd-trace/test/setup/mocha')
 const agent = require('../../dd-trace/test/plugins/agent')
@@ -25,8 +24,6 @@ describe('Plugin', function () {
 
       const startServer = ({ withConfig, standalone }, schemaVersion = 'v0', defaultToGlobalService = false) => {
         before(async () => {
-          port = await getPort()
-
           return agent.load('next')
         })
 
@@ -41,7 +38,7 @@ describe('Plugin', function () {
             env: {
               ...process.env,
               VERSION: version,
-              PORT: port,
+              PORT: 0,
               DD_TRACE_AGENT_PORT: agent.server.address().port,
               WITH_CONFIG: withConfig,
               DD_TRACE_SPAN_ATTRIBUTE_SCHEMA: schemaVersion,
@@ -56,8 +53,12 @@ describe('Plugin', function () {
           server.once('error', done)
 
           function waitUntilServerStarted (chunk) {
-            const chunkString = chunk.toString()
-            if (chunkString?.includes(port) || chunkString?.includes('Ready ')) {
+            const chunkStr = chunk.toString()
+            const match = chunkStr.match(/port:? (\d+)/) ||
+              chunkStr.match(/http:\/\/127\.0\.0\.1:(\d+)/)
+
+            if (match) {
+              port = Number(match[1])
               server.stdout.off('data', waitUntilServerStarted)
               done()
             }

packages/dd-trace/test/appsec/index.next.plugin.spec.js

@@ -2,7 +2,6 @@
 
 const { spawn, execSync } = require('child_process')
 const { cpSync, mkdirSync, rmdirSync, unlinkSync } = require('fs')
-const getPort = require('get-port')
 const axios = require('axios')
 const { writeFileSync } = require('fs')
 const { satisfies } = require('semver')
@@ -105,8 +104,6 @@ describe('test suite', () => {
       const appDir = path.join(__dirname, 'next', appName)
 
       before(async () => {
-        port = await getPort()
-
         return agent.load('next')
       })
 
@@ -119,7 +116,7 @@ describe('test suite', () => {
           env: {
             ...process.env,
             VERSION: version,
-            PORT: port,
+            PORT: 0,
             DD_TRACE_AGENT_PORT: agent.server.address().port,
             DD_TRACE_SPAN_ATTRIBUTE_SCHEMA: schemaVersion,
             DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED: defaultToGlobalService,
@@ -129,9 +126,20 @@ describe('test suite', () => {
         })
 
         server.once('error', done)
-        server.stdout.once('data', () => {
-          done()
-        })
+
+        function waitUntilServerStarted (chunk) {
+          const chunkStr = chunk.toString()
+          const match = chunkStr.match(/port:? (\d+)/) ||
+              chunkStr.match(/http:\/\/127\.0\.0\.1:(\d+)/)
+
+          if (match) {
+            port = Number(match[1])
+            server.stdout.off('data', waitUntilServerStarted)
+            done()
+          }
+        }
+        server.stdout.on('data', waitUntilServerStarted)
+
         server.stderr.on('data', chunk => process.stderr.write(chunk))
         server.stdout.on('data', chunk => process.stdout.write(chunk))
       })

packages/dd-trace/test/appsec/next/pages-dir/server.js

@@ -7,7 +7,7 @@ const { createServer } = require('http')
 const { parse } = require('url')
 const next = require('next')
 
-const app = next({ dir: __dirname, dev: false, quiet: true, hostname: HOSTNAME })
+const app = next({ dir: __dirname, dev: false, quiet: true, hostname: HOSTNAME, port: PORT })
 const handle = app.getRequestHandler()
 
 app.prepare().then(() => {