Skip to content

Commit 1d76ec0

Browse files
rochdevtlhunter
authored andcommitted
use the underlying array directly for IDs
1 parent be7b7e2 commit 1d76ec0

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

benchmark/sirun/plugin-koa/internal-tracer/encoder.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,6 @@ class Encoder {
205205
bytes.reserve(9)
206206
bytes.length += 9
207207

208-
id = id.toArray()
209-
210208
bytes.buffer[offset] = 0xcf
211209
bytes.buffer[offset + 1] = id[0]
212210
bytes.buffer[offset + 2] = id[1]

benchmark/sirun/plugin-koa/internal-tracer/id.js

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,7 @@ const { randomFillSync } = require('crypto')
55
const UINT_MAX = 4294967296
66

77
const data = new Uint8Array(8 * 8192)
8-
const zeroIdBuffer = new Uint8Array(8)
9-
const zeroId = {
10-
toArray: () => zeroIdBuffer,
11-
toString: () => '0',
12-
toJSON: () => '0'
13-
}
8+
const zeroId = new Uint8Array(8)
149

1510
let batch = 0
1611

@@ -19,11 +14,7 @@ function id (value, raddix) {
1914
? fromNumberString(value, raddix)
2015
: pseudoRandom()
2116

22-
return {
23-
toArray: () => buffer,
24-
toString: (raddix) => toNumberString(buffer, raddix),
25-
toJSON: () => toNumberString(buffer)
26-
}
17+
return buffer
2718
}
2819

2920
function pseudoRandom () {
@@ -123,4 +114,4 @@ function writeUInt32BE (buffer, value, offset) {
123114
buffer[0 + offset] = value & 255
124115
}
125116

126-
module.exports = { id, zeroId }
117+
module.exports = { id, zeroId, toNumberString }

0 commit comments

Comments
 (0)