Update Go runtime to 1.24.5 (#2057)

tbavelier · web-flow · commit 42c09181ae14 · 2025-07-21T15:45:27.000+02:00
* Update Go runtime to 1.24.5

* Update golangci-lint to 1.64.8 to support Go 1.24 and remove deactivated linters

* remove golangci-lint warning due to version bump

* fix lint errors

* Update licenses
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,5 +1,5 @@
 {
-	"image": "mcr.microsoft.com/devcontainers/go:dev-1.23",
+	"image": "mcr.microsoft.com/devcontainers/go:dev-1.24",
 	"features": {
 		"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {}
 	},
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,6 +1,6 @@
 name: Build
 env:
-  GO_VERSION: 1.23.10
+  GO_VERSION: 1.24.5
 on:
   push:
 # Permission forced by repo-level setting; only elevate on job-level
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -6,7 +6,7 @@ permissions:
   # packages: read
 env:
   PROJECTNAME: "datadog-operator"
-  GO_VERSION: 1.23.10
+  GO_VERSION: 1.24.5
 jobs:
   build:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -11,7 +11,7 @@ permissions:
   contents: read
   # packages: read
 env:
-  GO_VERSION: 1.23.10
+  GO_VERSION: 1.24.5
 jobs:
   build-linux-binary:
     if: startsWith(github.ref, 'refs/tags/v')
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -1,4 +1,4 @@
-image: registry.ddbuild.io/images/mirror/library/golang:1.23.10
+image: registry.ddbuild.io/images/mirror/library/golang:1.24.5
 variables:
   PROJECTNAME: "datadog-operator"
   PROJECTNAME_CHECK: "datadog-operator-check"
diff --git a/.golangci.toml b/.golangci.toml
@@ -44,20 +44,17 @@
   enable-all = true
   disable = [
     "exhaustruct",
-    "exportloopref",
     "nonamedreturns",
     "revive",
     "lll",
     "gosec",
     "dupl",
-    "execinquery",
     "gocyclo",
     "gochecknoinits",
     "gochecknoglobals",
     "funlen",
     "gocognit",
     "cyclop",
-    "gomnd",
     "wrapcheck",
     "forcetypeassert",
     "err113",
@@ -103,7 +100,8 @@
     "dupword",
     "intrange",
     "mnd",
-    "musttag"
+    "musttag",
+    "tenv"
   ]
 
 [issues]
diff --git a/Dockerfile b/Dockerfile
@@ -2,7 +2,7 @@
 ARG FIPS_ENABLED=false
 
 # Build the manager binary
-FROM golang:1.23.10 AS builder
+FROM golang:1.24.5 AS builder
 
 WORKDIR /workspace
 # Copy the Go Modules manifests
diff --git a/LICENSE-3rdparty.csv b/LICENSE-3rdparty.csv
@@ -42,7 +42,6 @@ core,github.com/cespare/xxhash/v2,MIT
 core,github.com/cihub/seelog,BSD-3-Clause
 core,github.com/davecgh/go-spew/spew,ISC
 core,github.com/dustin/go-humanize,MIT
-core,github.com/ebitengine/purego,Apache-2.0
 core,github.com/emicklei/go-restful/v3,MIT
 core,github.com/evanphx/json-patch/v5,BSD-3-Clause
 core,github.com/felixge/httpsnoop,MIT
@@ -122,7 +121,7 @@ core,go.opentelemetry.io/proto/otlp,Apache-2.0
 core,go.uber.org/atomic,MIT
 core,go.uber.org/multierr,MIT
 core,go.uber.org/zap,MIT
-core,golang.org/x/exp,BSD-3-Clause
+core,golang.org/x/exp/slices,BSD-3-Clause
 core,golang.org/x/mod/semver,BSD-3-Clause
 core,golang.org/x/net,BSD-3-Clause
 core,golang.org/x/oauth2,BSD-3-Clause
diff --git a/Makefile b/Makefile
@@ -342,7 +342,7 @@ bin/$(PLATFORM)/jq: Makefile
 	hack/install-jq.sh 1.7.1
 
 bin/$(PLATFORM)/golangci-lint: Makefile
-	hack/golangci-lint.sh -b "bin/$(PLATFORM)" v1.61.0
+	hack/golangci-lint.sh -b "bin/$(PLATFORM)" v1.64.8
 
 bin/$(PLATFORM)/operator-sdk: Makefile
 	hack/install-operator-sdk.sh v1.34.1
diff --git a/api/go.mod b/api/go.mod
@@ -1,8 +1,8 @@
 module github.com/DataDog/datadog-operator/api
 
-go 1.23
+go 1.24
 
-toolchain go1.23.10
+toolchain go1.24.5
 
 require (
 	github.com/DataDog/datadog-api-client-go/v2 v2.34.0
diff --git a/check-operator.Dockerfile b/check-operator.Dockerfile
@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.23.10 AS builder
+FROM golang:1.24.5 AS builder
 
 WORKDIR /workspace
 # Copy the Go Modules manifests
diff --git a/go.mod b/go.mod
@@ -1,8 +1,8 @@
 module github.com/DataDog/datadog-operator
 
-go 1.23
+go 1.24
 
-toolchain go1.23.10
+toolchain go1.24.5
 
 replace github.com/DataDog/extendeddaemonset v0.10.0-rc.4 => github.com/DataDog/extendeddaemonset/api v0.0.0-20250108205105-6c4d337b78a1
 
diff --git a/go.work b/go.work
@@ -1,6 +1,6 @@
-go 1.23.10
+go 1.24.5
 
-toolchain go1.23.10
+toolchain go1.24.5
 
 use (
 	.
diff --git a/internal/controller/datadogagent/feature/processdiscovery/feature.go b/internal/controller/datadogagent/feature/processdiscovery/feature.go
@@ -33,7 +33,7 @@ type processDiscoveryFeature struct {
 	runInCoreAgent bool
 }
 
-func (p processDiscoveryFeature) ID() feature.IDType {
+func (p *processDiscoveryFeature) ID() feature.IDType {
 	return feature.ProcessDiscoveryIDType
 }
 
@@ -60,15 +60,15 @@ func (p *processDiscoveryFeature) Configure(_ metav1.Object, ddaSpec *v2alpha1.D
 	return reqComp
 }
 
-func (p processDiscoveryFeature) ManageDependencies(managers feature.ResourceManagers) error {
+func (p *processDiscoveryFeature) ManageDependencies(managers feature.ResourceManagers) error {
 	return nil
 }
 
-func (p processDiscoveryFeature) ManageClusterAgent(managers feature.PodTemplateManagers) error {
+func (p *processDiscoveryFeature) ManageClusterAgent(managers feature.PodTemplateManagers) error {
 	return nil
 }
 
-func (p processDiscoveryFeature) ManageNodeAgent(managers feature.PodTemplateManagers, provider string) error {
+func (p *processDiscoveryFeature) ManageNodeAgent(managers feature.PodTemplateManagers, provider string) error {
 	// Always add this envvar to Core and Process containers
 	runInCoreAgentEnvVar := &corev1.EnvVar{
 		Name:  common.DDProcessConfigRunInCoreAgent,
@@ -85,7 +85,7 @@ func (p processDiscoveryFeature) ManageNodeAgent(managers feature.PodTemplateMan
 	return nil
 }
 
-func (p processDiscoveryFeature) ManageSingleContainerNodeAgent(managers feature.PodTemplateManagers, provider string) error {
+func (p *processDiscoveryFeature) ManageSingleContainerNodeAgent(managers feature.PodTemplateManagers, provider string) error {
 	runInCoreAgentEnvVar := &corev1.EnvVar{
 		Name:  common.DDProcessConfigRunInCoreAgent,
 		Value: apiutils.BoolToString(&p.runInCoreAgent),
@@ -95,7 +95,7 @@ func (p processDiscoveryFeature) ManageSingleContainerNodeAgent(managers feature
 	return nil
 }
 
-func (p processDiscoveryFeature) manageNodeAgent(agentContainerName apicommon.AgentContainerName, managers feature.PodTemplateManagers, provider string) error {
+func (p *processDiscoveryFeature) manageNodeAgent(agentContainerName apicommon.AgentContainerName, managers feature.PodTemplateManagers, provider string) error {
 	// passwd volume mount
 	passwdVol, passwdVolMount := volume.GetVolumes(common.PasswdVolumeName, common.PasswdHostPath, common.PasswdMountPath, true)
 	managers.VolumeMount().AddVolumeMountToContainer(&passwdVolMount, agentContainerName)
@@ -121,6 +121,6 @@ func (p processDiscoveryFeature) manageNodeAgent(agentContainerName apicommon.Ag
 	return nil
 }
 
-func (p processDiscoveryFeature) ManageClusterChecksRunner(managers feature.PodTemplateManagers) error {
+func (p *processDiscoveryFeature) ManageClusterChecksRunner(managers feature.PodTemplateManagers) error {
 	return nil
 }
diff --git a/internal/controller/datadogagent/feature/sbom/feature.go b/internal/controller/datadogagent/feature/sbom/feature.go
@@ -131,9 +131,9 @@ func (f *sbomFeature) ManageClusterAgent(managers feature.PodTemplateManagers) e
 	return nil
 }
 
-func (p sbomFeature) ManageSingleContainerNodeAgent(managers feature.PodTemplateManagers, provider string) error {
+func (f *sbomFeature) ManageSingleContainerNodeAgent(managers feature.PodTemplateManagers, provider string) error {
 	// This feature doesn't set env vars on specific containers, so no specific logic for the single agent
-	p.ManageNodeAgent(managers, provider)
+	f.ManageNodeAgent(managers, provider)
 	return nil
 }
 
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -7,11 +7,11 @@ package config
 
 import (
 	"fmt"
+	"maps"
 	"os"
 	"strings"
 
 	"github.com/go-logr/logr"
-	"golang.org/x/exp/maps"
 	corev1 "k8s.io/api/core/v1"
 	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
diff --git a/test/e2e/go.mod b/test/e2e/go.mod
@@ -1,8 +1,8 @@
 module github.com/DataDog/datadog-operator/test/e2e
 
-go 1.23
+go 1.24
 
-toolchain go1.23.10
+toolchain go1.24.5
 
 replace (
 	github.com/DataDog/datadog-agent/comp/core/tagger/types => github.com/DataDog/datadog-agent/comp/core/tagger/types v0.63.0-rc.1
diff --git a/test/e2e/tests/utils/utils.go b/test/e2e/tests/utils/utils.go
@@ -6,7 +6,6 @@
 package utils
 
 import (
-	"context"
 	"strconv"
 	"strings"
 	"testing"
@@ -25,7 +24,7 @@ func VerifyOperator(t *testing.T, c *assert.CollectT, namespace string, k8sClien
 
 func VerifyNumPodsForSelector(t *testing.T, c *assert.CollectT, namespace string, k8sClient kubeClient.Interface, numPods int, selector string) {
 	t.Log("Waiting for number of pods created", "number", numPods, "selector", selector)
-	podsList, err := k8sClient.CoreV1().Pods(namespace).List(context.TODO(), metav1.ListOptions{
+	podsList, err := k8sClient.CoreV1().Pods(namespace).List(t.Context(), metav1.ListOptions{
 		LabelSelector: selector,
 		FieldSelector: "status.phase=Running",
 	})
@@ -36,7 +35,7 @@ func VerifyNumPodsForSelector(t *testing.T, c *assert.CollectT, namespace string
 }
 
 func VerifyAgentPods(t *testing.T, c *assert.CollectT, namespace string, k8sClient kubeClient.Interface, selector string) {
-	nodesList, err := k8sClient.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{})
+	nodesList, err := k8sClient.CoreV1().Nodes().List(t.Context(), metav1.ListOptions{})
 	require.NoError(c, err)
 	assert.NotNil(c, nodesList)
 	assert.NotEmpty(c, nodesList.Items)

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "image": "mcr.microsoft.com/devcontainers/go:dev-1.23",`
	`2`	`+ "image": "mcr.microsoft.com/devcontainers/go:dev-1.24",`
`3`	`3`	`"features": {`
`4`	`4`	`"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {}`
`5`	`5`	`},`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-image: registry.ddbuild.io/images/mirror/library/golang:1.23.10`
	`1`	`+image: registry.ddbuild.io/images/mirror/library/golang:1.24.5`
`2`	`2`	`variables:`
`3`	`3`	`PROJECTNAME: "datadog-operator"`
`4`	`4`	`PROJECTNAME_CHECK: "datadog-operator-check"`