You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what happened:
Datadog webhook adds init containers with invalid resource spec. CPU limit can be smaller than request which is not allowed. This happens if there are multiple container in a pod where the sum all limits is smaller than the sum of all requests (e.g. because on container does not have a limit at all).
Describe what you expected:
Datadog Admission controller does not create invalid spec.
Steps to reproduce the issue:
Create a pod with two containers like this:
Agent Environment
Describe what happened:
Datadog webhook adds init containers with invalid resource spec. CPU limit can be smaller than request which is not allowed. This happens if there are multiple container in a pod where the sum all limits is smaller than the sum of all requests (e.g. because on container does not have a limit at all).
Describe what you expected:
Datadog Admission controller does not create invalid spec.
Steps to reproduce the issue:
Create a pod with two containers like this:
Additional environment details (Operating System, Cloud provider, etc):
GKE.
The code that does this calculation wrong is probably here: https://github.com/DataDog/datadog-agent/blob/main/pkg/clusteragent/admission/mutate/autoinstrumentation/auto_instrumentation.go#L288
Seems to have been introduced with #30266
The text was updated successfully, but these errors were encountered: