Skip to content

Commit ea3032f

Browse files
[backport 7.66.x] Backport #36686 (#36722)
Co-authored-by: agent-platform-auto-pr[bot] <153269286+agent-platform-auto-pr[bot]@users.noreply.github.com>
1 parent 642f550 commit ea3032f

File tree

6 files changed

+20
-15
lines changed

6 files changed

+20
-15
lines changed

.gitlab/common/test_infra_version.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
---
77
variables:
8-
TEST_INFRA_DEFINITIONS_BUILDIMAGES: d610d4c9aa4b
8+
TEST_INFRA_DEFINITIONS_BUILDIMAGES: fa71308022b9
99
TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX: ''

test/new-e2e/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ require (
2323
// `TEST_INFRA_DEFINITIONS_BUILDIMAGES` matches the commit sha in the module version
2424
// Example: github.com/DataDog/test-infra-definitions v0.0.0-YYYYMMDDHHmmSS-0123456789AB
2525
// => TEST_INFRA_DEFINITIONS_BUILDIMAGES: 0123456789AB
26-
github.com/DataDog/test-infra-definitions v0.0.0-20250410185122-d610d4c9aa4b
26+
github.com/DataDog/test-infra-definitions v0.0.0-20250506103533-fa71308022b9
2727
github.com/aws/aws-sdk-go-v2 v1.36.3
2828
github.com/aws/aws-sdk-go-v2/config v1.29.11
2929
github.com/aws/aws-sdk-go-v2/service/ec2 v1.210.1

test/new-e2e/go.sum

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/new-e2e/tests/containers/docker_test.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ import (
1212
"testing"
1313
"time"
1414

15+
"github.com/DataDog/test-infra-definitions/components/datadog/apps/redis"
16+
1517
"github.com/DataDog/datadog-agent/test/new-e2e/pkg/e2e"
1618
"github.com/DataDog/datadog-agent/test/new-e2e/pkg/environments"
1719
awsdocker "github.com/DataDog/datadog-agent/test/new-e2e/pkg/provisioners/aws/docker"
@@ -59,10 +61,10 @@ func (suite *DockerSuite) TestDockerMetrics() {
5961
expectedTags := append([]string{
6062
`^container_id:`,
6163
`^container_name:redis$`,
62-
`^docker_image:public.ecr.aws/docker/library/redis:latest$`,
64+
fmt.Sprintf(`^docker_image:public.ecr.aws/docker/library/redis:%s$`, redis.RedisVersion),
6365
`^image_id:sha256:`,
6466
`^image_name:public.ecr.aws/docker/library/redis$`,
65-
`^image_tag:latest$`,
67+
fmt.Sprintf(`^image_tag:%s$`, redis.RedisVersion),
6668
`^runtime:docker$`,
6769
`^short_image:redis$`,
6870
}, extraTags...)
@@ -113,10 +115,10 @@ func (suite *DockerSuite) TestDockerMetrics() {
113115
},
114116
Expect: testMetricExpectArgs{
115117
Tags: &[]string{
116-
`^docker_image:public.ecr.aws/docker/library/redis:latest$`,
118+
fmt.Sprintf(`^docker_image:public.ecr.aws/docker/library/redis:%s$`, redis.RedisVersion),
117119
`^image_id:sha256:`,
118120
`^image_name:public.ecr.aws/docker/library/redis$`,
119-
`^image_tag:latest$`,
121+
fmt.Sprintf(`^image_tag:%s$`, redis.RedisVersion),
120122
`^short_image:redis$`,
121123
},
122124
Value: &testMetricExpectValueArgs{

test/new-e2e/tests/containers/ecs_test.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ package containers
77

88
import (
99
"context"
10+
"fmt"
1011
"regexp"
1112
"strings"
1213
"testing"
@@ -24,6 +25,7 @@ import (
2425
"github.com/stretchr/testify/assert"
2526
"github.com/stretchr/testify/require"
2627

28+
"github.com/DataDog/test-infra-definitions/components/datadog/apps/redis"
2729
tifecs "github.com/DataDog/test-infra-definitions/scenarios/aws/ecs"
2830

2931
envecs "github.com/DataDog/datadog-agent/test/new-e2e/pkg/provisioners/aws/ecs"
@@ -251,14 +253,14 @@ func (suite *ecsSuite) TestRedisECS() {
251253
`^cluster_name:` + regexp.QuoteMeta(suite.ecsClusterName) + `$`,
252254
`^container_id:`,
253255
`^container_name:ecs-.*-redis-ec2-`,
254-
`^docker_image:public.ecr.aws/docker/library/redis:latest$`,
256+
fmt.Sprintf(`^docker_image:public.ecr.aws/docker/library/redis:%s$`, redis.RedisVersion),
255257
`^ecs_cluster_name:` + regexp.QuoteMeta(suite.ecsClusterName) + `$`,
256258
`^ecs_container_name:redis$`,
257259
`^ecs_service:` + regexp.QuoteMeta(strings.TrimSuffix(suite.ecsClusterName, "-ecs")) + `-redis-ec2$`,
258260
`^ecs_launch_type:ec2$`,
259261
`^image_id:sha256:`,
260262
`^image_name:public.ecr.aws/docker/library/redis$`,
261-
`^image_tag:latest$`,
263+
fmt.Sprintf(`^image_tag:%s$`, redis.RedisVersion),
262264
`^region:us-east-1$`,
263265
`^short_image:redis$`,
264266
`^task_arn:`,
@@ -281,14 +283,14 @@ func (suite *ecsSuite) TestRedisECS() {
281283
`^cluster_name:` + regexp.QuoteMeta(suite.ecsClusterName) + `$`,
282284
`^container_id:`,
283285
`^container_name:ecs-.*-redis-ec2-`,
284-
`^docker_image:public.ecr.aws/docker/library/redis:latest$`,
286+
fmt.Sprintf(`^docker_image:public.ecr.aws/docker/library/redis:%s$`, redis.RedisVersion),
285287
`^ecs_cluster_name:` + regexp.QuoteMeta(suite.ecsClusterName) + `$`,
286288
`^ecs_container_name:redis$`,
287289
`^ecs_launch_type:ec2$`,
288290
`^ecs_service:` + regexp.QuoteMeta(strings.TrimSuffix(suite.ecsClusterName, "-ecs")) + `-redis-ec2$`,
289291
`^image_id:sha256:`,
290292
`^image_name:public.ecr.aws/docker/library/redis$`,
291-
`^image_tag:latest$`,
293+
fmt.Sprintf(`^image_tag:%s$`, redis.RedisVersion),
292294
`^region:us-east-1$`,
293295
`^short_image:redis$`,
294296
`^task_arn:arn:`,
@@ -357,7 +359,7 @@ func (suite *ecsSuite) TestRedisFargate() {
357359
`^ecs_launch_type:fargate`,
358360
`^image_id:sha256:`,
359361
`^image_name:public.ecr.aws/docker/library/redis$`,
360-
`^image_tag:latest$`,
362+
fmt.Sprintf(`^image_tag:%s$`, redis.RedisVersion),
361363
`^region:us-east-1$`,
362364
`^short_image:redis$`,
363365
`^task_arn:`,

test/new-e2e/tests/containers/k8s_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616

1717
"github.com/DataDog/agent-payload/v5/cyclonedx_v1_4"
1818
"github.com/DataDog/agent-payload/v5/sbom"
19+
"github.com/DataDog/test-infra-definitions/components/datadog/apps/redis"
1920
"gopkg.in/zorkian/go-datadog-api.v2"
2021

2122
"github.com/DataDog/datadog-agent/pkg/util/pointer"
@@ -628,7 +629,7 @@ func (suite *k8sSuite) TestRedis() {
628629
`^display_container_name:redis`,
629630
`^image_id:public.ecr.aws/docker/library/redis@sha256:`,
630631
`^image_name:public.ecr.aws/docker/library/redis$`,
631-
`^image_tag:latest$`,
632+
fmt.Sprintf(`^image_tag:%s$`, redis.RedisVersion),
632633
`^kube_container_name:redis$`,
633634
`^kube_deployment:redis$`,
634635
`^kube_namespace:workload-redis$`,
@@ -684,7 +685,7 @@ func (suite *k8sSuite) TestRedis() {
684685
`^filename:[[:digit:]]+.log$`,
685686
`^image_id:public.ecr.aws/docker/library/redis@sha256:`,
686687
`^image_name:public.ecr.aws/docker/library/redis$`,
687-
`^image_tag:latest$`,
688+
fmt.Sprintf(`^image_tag:%s$`, redis.RedisVersion),
688689
`^kube_container_name:redis$`,
689690
`^kube_deployment:redis$`,
690691
`^kube_namespace:workload-redis$`,

0 commit comments

Comments
 (0)