Skip to content

Commit d0036d9

Browse files
authored
discovery: send Service Discovery telemetry (#35869)
1 parent 1cb2fe5 commit d0036d9

File tree

4 files changed

+21
-2
lines changed

4 files changed

+21
-2
lines changed

comp/core/agenttelemetry/impl/agenttelemetry_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@ func TestRun(t *testing.T) {
478478
profile0Len := len(r.(*runnerMock).jobs[0].profiles)
479479
profile1Len := len(r.(*runnerMock).jobs[1].profiles)
480480
t.Logf("%+v", r.(*runnerMock).jobs)
481-
assert.True(t, (profile0Len == 1 && profile1Len == 4) || (profile0Len == 4 && profile1Len == 1))
481+
assert.True(t, (profile0Len == 1 && profile1Len == 5) || (profile0Len == 5 && profile1Len == 1))
482482
}
483483

484484
func TestReportMetricBasic(t *testing.T) {

comp/core/agenttelemetry/impl/config.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,14 @@ var defaultProfiles = `
283283
aggregate_tags:
284284
- kind
285285
- template_name
286+
- name: service-discovery
287+
metric:
288+
metrics:
289+
- name: service_discovery.discovered_services
290+
schedule:
291+
start_after: 30
292+
iterations: 0
293+
period: 900
286294
`
287295

288296
func compileMetricsExclude(p *Profile) error {

pkg/collector/corechecks/servicediscovery/servicediscovery.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ func (c *Check) Configure(senderManager sender.SenderManager, _ uint64, instance
9494
"discovered_services",
9595
[]string{},
9696
"Number of discovered alive services.",
97-
telemetry.Options{NoDoubleUnderscoreSep: true},
97+
telemetry.DefaultOptions,
9898
)
9999

100100
return nil
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Each section from every release note are combined when the
2+
# CHANGELOG.rst is rendered. So the text needs to be worded so that
3+
# it does not depend on any information only available in another
4+
# section. This may mean repeating some details, but each section
5+
# must be readable independently of the other.
6+
#
7+
# Each section note must be formatted as reStructuredText.
8+
---
9+
other:
10+
- |
11+
Adds Agent telemetry for Service Discovery.

0 commit comments

Comments
 (0)