feat(node_failure): increase flush interval (#738)

luphaz · web-flow · commit d3228a9ceb4d · 2023-07-17T11:09:07.000+02:00
diff --git a/injector/node_failure.go b/injector/node_failure.go
@@ -52,7 +52,7 @@ func NewNodeFailureInjector(spec v1beta1.NodeFailureSpec, config NodeFailureInje
 	}
 
 	if config.WaitBeforeShutdown == 0 {
-		config.WaitBeforeShutdown = 10 * time.Second
+		config.WaitBeforeShutdown = 31 * time.Second
 	}
 
 	return &nodeFailureInjector{
@@ -82,7 +82,7 @@ func (i *nodeFailureInjector) Inject() error {
 	}
 
 	// Trigger kernel panic
-	i.config.Log.Infow("the injector will write to the sysrq trigger file in 10s")
+	i.config.Log.Infof("the injector will write to the sysrq trigger file in %v", i.config.WaitBeforeShutdown)
 	i.config.Log.Infow("from this point, if no fatal log occurs, the injection succeeded and the system will crash")
 	_ = i.config.Log.Sync() // If we can't flush the logger, why would logging the error help? so we just ignore
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ func NewNodeFailureInjector(spec v1beta1.NodeFailureSpec, config NodeFailureInje`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`if config.WaitBeforeShutdown == 0 {`
`55`		`- config.WaitBeforeShutdown = 10 * time.Second`
	`55`	`+ config.WaitBeforeShutdown = 31 * time.Second`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`return &nodeFailureInjector{`
`@@ -82,7 +82,7 @@ func (i *nodeFailureInjector) Inject() error {`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`// Trigger kernel panic`
`85`		`- i.config.Log.Infow("the injector will write to the sysrq trigger file in 10s")`
	`85`	`+ i.config.Log.Infof("the injector will write to the sysrq trigger file in %v", i.config.WaitBeforeShutdown)`
`86`	`86`	`i.config.Log.Infow("from this point, if no fatal log occurs, the injection succeeded and the system will crash")`
`87`	`87`	`_ = i.config.Log.Sync() // If we can't flush the logger, why would logging the error help? so we just ignore`
`88`	`88`