Improve UX in light mode

[Jakub-Vacek]

Improve colors when using "light mode" on your Mac.

• Color of TextField text, labels and icons should be more contrasting (black).
• Text in TextField after saving configuration should disappear.
• Background color should be white
• Save button should have label.

Current state:

[jamie-brannan]

Hello! Happy to have found this issue via Hacktoberfest. 🎃 I'd love to contribute, and have an idea of some WCAG 2.0 accessible contrasts that would do the trick. However most of my experience with swift is in Swift 5 on iOS. I hope this won't be an issue for contributing?

[prokopsimek]

@jamie-brannan Hello Jamie! Do not hesitate to at least try to fix the contrast! 👏✅

If you have any questions do not hesitate to contact us me or @Jakub-Vacek.

[jamie-brannan]

Awesome, will do! Thank you! 🚀

[jamie-brannan]

Hello again @prokopsimek , quick question – in reading your contribution guide I see you have commit conventions but would you like me to follow any particular branch naming conventions?

[adelkahomolova]

Hi, @jamie-brannan . We use the fix branch for fixes and the feature branch for features sometimes also chore or hotfix. So the branch should be named something like fix/improve-ux or feature/light-mode or something like that. Is it clearer now for you? :)

[jamie-brannan]

Yes thank you 😊

[jamie-brannan]

Hello 👋 I have a few more questions about getting my environment and contributing set up.

I've got macOS 11 beta installed, Xcode 12, PromiseKit and AwaitKit – my only issue is resolving signing certificates before I can build. Or is this not necessary?

About branching, I'm new to contributing but I was wondering if it's standard procedure to always fork, then create a branch from there and a PR – simply to commit to my fork directly before creating a PR?

[Jakub-Vacek]

Hello 🙂Signing of certificates is not necessary. This is project setup which works for me:

Branching: your approach is ok 👌