Skip to content

Commit eb2e920

Browse files
authored
feat(basicSql): remove judge splitListener/collectListener, all sqlParser implements it (#316)
1 parent 4dac703 commit eb2e920

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/parser/common/basicSQL.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,6 @@ export abstract class BasicSQL<
231231
return null;
232232
}
233233
const splitListener = this.splitListener;
234-
// TODO: add splitListener to all sqlParser implements and remove following if
235-
if (!splitListener) return null;
236234

237235
this.listen(splitListener, this._parseTree);
238236

@@ -256,8 +254,6 @@ export abstract class BasicSQL<
256254
caretPosition: CaretPosition
257255
): Suggestions | null {
258256
const splitListener = this.splitListener;
259-
// TODO: add splitListener to all sqlParser implements and remove following if
260-
if (!splitListener) return null;
261257

262258
this.parseWithCache(input);
263259
if (!this._parseTree) return null;
@@ -383,10 +379,6 @@ export abstract class BasicSQL<
383379
: void 0;
384380

385381
const collectListener = this.createEntityCollector(input, caretTokenIndex);
386-
// TODO: add entityCollector to all sqlParser implements and remove following if
387-
if (!collectListener) {
388-
return null;
389-
}
390382
// const parser = this.createParserWithCache(input);
391383

392384
// parser.entityCollecting = true;

0 commit comments

Comments
 (0)