Skip to content

Docker improvments #47

@Tokariew

Description

@Tokariew

System with selinux will fail to run docker command from readme. They require additional ":z" option in volume mount. The ":z" option shouldn't mess with system without selinux

So should look like this.

docker run -v $(PWD)/download:/download:z --rm -it dmarby/humblebundle-ebook-downloader -d /download --auth-token "auth_string_here"

I think _simpleauth_sess shouldn't be visible in command history, so it will be probably good to have option to pass it as environment variables with --env-file option. But this will require modifying program probably…

As this program don't require elevated privileges maybe it should be run with podman instead of docker, which don't require root, and it will not mess file permissions on linux. If it will stay docker it would be nice to add "-u" option from docker. Than files will no longer belong to root. This is probably unix only…

docker run -v $(PWD)/download:/download:z -u $(id -u) --rm -it dmarby/humblebundle-ebook-downloader -d /download --auth-token "auth_string_here"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions