Should Bonus and Feedback really be properties of judgements?

[oleks]

The AST currently sais that:

data Judgement
  = Judgement (Header, [Property], [Comment], [Judgement])
  | Bonus (Int, [Property], [Comment])
  | Feedback ([Property], String)

This suggests that the following should be an OK remarks file:

# Feedback
  * Great work!

However, it is not. Feedback processing fails unless the feedback judgement occurs as the first and not only child of another judgement.. That may be buggy feedback processing, but then the Feedback judgement is really a holistic (rather than analytical) judgement, which does not even have a score, but just a description of how good the work is. Such judgements are of course, not composable. If we want such judgements (I don't think we do), such a description may, or may not be good enough as feedback for a student, and they should be called something other than "Feedback".

I think feedback is better positioned as a property. This allows to mandate that a score is still given, on a syntactic level.

# Assignment 1: 1/1
  :Feedback:
    * Great work!

The above AST also suggests that this should be an OK remarks file:

# Bonus: +9000
  * Exceptional work

I do not see the purpose of this one at all.

Bonus too should probably just be a property:

# Assignment 1: 100/100
:Bonus: +30
  * Implemented in point-free style
## Implementation: 30/40
## Test: 30/40
## Report: 10/20

This is related to #28

@kirkedal