Move initializing notifications

Author: DFreds

src/ts/effects/effect-definition.ts

@@ -16,11 +16,17 @@ abstract class EffectDefinition {
 
     async initialize(): Promise<void> {
         if (BUILD_MODE === "development" || !this.settings.hasInitialized) {
+            ui.notifications.info(
+                game.i18n.localize("ConvenientEffects.Initializing"),
+            );
             await this.#createItemsAndEffects({ backup: false });
             await this.#createItemsAndEffects({ backup: true });
 
             // Set initialized before migration runs
             await this.settings.setHasInitialized(true);
+            ui.notifications.info(
+                game.i18n.localize("ConvenientEffects.FinishedInitializing"),
+            );
         }
 
         await this.#runMigrations();

src/ts/hooks/createEffects.ts

@@ -20,11 +20,7 @@ const CreateEffects: Listener = {
             const systemDefinition = mapping.findSystemDefinitionForSystemId();
 
             try {
-                ui.notifications.info(`Initializing convenient effects...`);
                 await systemDefinition?.effectDefinition?.initialize();
-                ui.notifications.info(
-                    `Finished initializing convenient effects`,
-                );
             } catch (e: any) {
                 ui.notifications.error(
                     `Something went wrong while initializing convenient effects`,

static/lang/en.json

@@ -69,6 +69,9 @@
         "ConfigOtherEffectsLabel": "Other Effects",
         "ConfigOtherEffectsHint": "The other effects that will be applied in relation to this effect. If this effect is removed, the other effects will not be automatically removed.",
 
+        "Initializing": "Initializing convenient effects...",
+        "FinishedInitializing": "Finished initializing convenient effects",
+
         "Dnd": {
             "Folders": {
                 "Conditions": "Conditions",