Skip to content

Commit ee54291

Browse files
Merge pull request #418 from DFE-Digital/feature/trust-v4-endpoint
bugfix - PhaseOfEducationCode int not string Added trust type
2 parents 3f9d005 + e8a497a commit ee54291

File tree

8 files changed

+8
-7
lines changed

8 files changed

+8
-7
lines changed

Dfe.Academies.Api.Infrastructure/Dfe.Academies.Infrastructure.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<ItemGroup>
1010
<PackageReference Include="CsvHelper" Version="30.0.1" />
11-
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.5" />
11+
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.7" />
1212
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.24" />
1313
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="6.0.24">
1414
<PrivateAssets>all</PrivateAssets>

Dfe.Academies.Application/Builders/EstablishmentDtoBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public EstablishmentDtoBuilder WithPhaseOfEducation(Domain.Establishment.Establi
8080
_dto.PhaseOfEducation = new NameAndCodeDto
8181
{
8282
Name = establishment?.PhaseOfEducation,
83-
Code = establishment?.PhaseOfEducationCode
83+
Code = establishment?.PhaseOfEducationCode.ToString()
8484
};
8585

8686
return this;

Dfe.Academies.Application/Dfe.Academies.Application.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.5" />
10+
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.7" />
1111
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="7.0.0" />
1212
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="7.0.0" />
1313
</ItemGroup>

Dfe.Academies.Application/Queries/Trust/TrustQueries.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ private static TrustDto MapToTrustDto(Domain.Trust.Trust trust)
5050
CompaniesHouseNumber = trust.CompaniesHouseNumber,
5151
ReferenceNumber = trust.GroupID,
5252
Ukprn = trust.UKPRN,
53+
Type = new Contracts.V4.Establishments.NameAndCodeDto() { Code = trust.TrustType.Code, Name = trust.TrustType.Name },
5354
Address = new AddressDto()
5455
{
5556
Street = trust.AddressLine1,

Dfe.Academies.Domain/Dfe.Academies.Domain.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.5" />
10+
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.7" />
1111
</ItemGroup>
1212

1313
</Project>

Dfe.Academies.Domain/Establishment/Establishment.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public class Establishment
9595
public string? GORregionCode { get; set; }
9696
public string? ReligiousCharacterCode { get; set; }
9797
public string? ParliamentaryConstituencyCode { get; set; }
98-
public string? PhaseOfEducationCode { get; set; }
98+
public int? PhaseOfEducationCode { get; set; }
9999
public int? SenUnitCapacity { get; set; }
100100
public int? SenUnitOnRoll { get; set; }
101101

TramsDataApi.Test/TramsDataApi.Test.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<PackageReference Include="AutoFixture.AutoMoq" Version="4.18.0" />
1717
<PackageReference Include="AutoFixture.Idioms" Version="4.18.0" />
1818
<PackageReference Include="AutoFixture.Xunit2" Version="4.18.0" />
19-
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.5" />
19+
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.7" />
2020
<PackageReference Include="FluentAssertions" Version="6.11.0" />
2121
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="6.0.19" />
2222
<PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="7.0.0" />

TramsDataApi/TramsDataApi.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</PropertyGroup>
77
<ItemGroup>
88
<PackageReference Include="CsvHelper" Version="30.0.1" />
9-
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.5" />
9+
<PackageReference Include="Dfe.Academies.Contracts" Version="1.0.7" />
1010
<PackageReference Include="Dfe.Academisation.CorrelationIdMiddleware" Version="2.0.2" />
1111
<PackageReference Include="FluentValidation" Version="11.6.0" />
1212
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.21.0" />

0 commit comments

Comments
 (0)