Skip to content

Commit bdf0224

Browse files
committed
Split workflow into concurrent build and import stages
* This makes it easier for us to manage the individual docker stages for both the main api and the init container
1 parent 5f5aa35 commit bdf0224

File tree

1 file changed

+55
-40
lines changed

1 file changed

+55
-40
lines changed

.github/workflows/build-and-push-image.yml

Lines changed: 55 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -14,89 +14,104 @@ on:
1414
concurrency:
1515
group: ${{ github.workflow }}-${{ github.event.inputs.environment }}
1616

17+
env:
18+
IMAGE_NAME: tramsapi-app
19+
1720
jobs:
1821
set-env:
1922
name: Determine environment
2023
runs-on: ubuntu-24.04
2124
outputs:
2225
environment: ${{ steps.var.outputs.environment }}
23-
branch: ${{ steps.var.outputs.branch }}
2426
release: ${{ steps.var.outputs.release }}
25-
checked-out-sha: ${{ steps.var.outputs.checked-out-sha }}
27+
image-name: ${{ steps.var.outputs.image-name }}
2628
steps:
2729
- name: Checkout
2830
uses: actions/checkout@v4
2931

30-
- name: Get branch name for push/dispatch event
31-
run: |
32-
GIT_REF=${{ github.ref_name }}
33-
echo "branch_ref=${GIT_REF}" >> $GITHUB_ENV
34-
3532
- id: var
3633
run: |
37-
GIT_REF=${{ env.branch_ref }}
38-
GIT_BRANCH=${GIT_REF##*/}
3934
INPUT=${{ github.event.inputs.environment }}
4035
ENVIRONMENT=${INPUT:-"development"}
41-
CHECKED_OUT_SHA="$(git log -1 '--format=format:%H')"
4236
RELEASE=${ENVIRONMENT,,}-`date +%Y-%m-%d`.${{ github.run_number }}
4337
echo "environment=${ENVIRONMENT,,}" >> $GITHUB_OUTPUT
44-
echo "branch=$GIT_BRANCH" >> $GITHUB_OUTPUT
45-
echo "checked-out-sha=${CHECKED_OUT_SHA}" >> $GITHUB_OUTPUT
4638
echo "release=${RELEASE}" >> $GITHUB_OUTPUT
39+
echo "image-name=${{ env.IMAGE_NAME }}" >> $GITHUB_OUTPUT
4740
48-
build-import-init-container:
41+
build:
42+
name: Build
43+
needs: [ set-env ]
4944
permissions:
50-
id-token: write
51-
contents: read
5245
packages: write
53-
name: Build and import Init Container
54-
needs: [ set-env ]
55-
uses: DFE-Digital/deploy-azure-container-apps-action/.github/workflows/build-push-deploy.yml@v3.1.0
46+
uses: DFE-Digital/deploy-azure-container-apps-action/.github/workflows/build.yml@v4.1.0
47+
strategy:
48+
matrix:
49+
stage: [
50+
"final",
51+
"initcontainer"
52+
]
53+
include:
54+
- stage: "final"
55+
tag-prefix: ""
56+
- stage: "initcontainer"
57+
tag-prefix: "init-"
5658
with:
57-
docker-image-name: tramsapi-app
58-
docker-build-target: initcontainer
59-
docker-tag-prefix: init-
6059
environment: ${{ needs.set-env.outputs.environment }}
61-
import-without-deploy: true
60+
docker-image-name: ${{ needs.set-env.outputs.image-name }}
61+
docker-build-file-name: ${{ inputs.docker-build-file-name }}
62+
docker-build-context: ${{ inputs.docker-build-context }}
6263
docker-build-args: CI=true
64+
docker-build-target: ${{ matrix.stage }}
65+
docker-tag-prefix: ${{ matrix.tag-prefix }}
66+
67+
import:
68+
name: Import
69+
needs: [ set-env, build ]
70+
permissions:
71+
id-token: write
72+
uses: DFE-Digital/deploy-azure-container-apps-action/.github/workflows/import.yml@v4.1.0
73+
strategy:
74+
matrix:
75+
stage: [
76+
"final",
77+
"initcontainer"
78+
]
79+
include:
80+
- stage: "final"
81+
tag-prefix: ""
82+
- stage: "initcontainer"
83+
tag-prefix: "init-"
84+
with:
85+
environment: ${{ needs.set-env.outputs.environment }}
86+
docker-image-name: ${{ needs.set-env.outputs.image-name }}
87+
docker-tag-prefix: ${{ matrix.tag-prefix }}
6388
secrets:
6489
azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
6590
azure-subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
6691
azure-acr-client-id: ${{ secrets.ACR_CLIENT_ID }}
6792
azure-acr-name: ${{ secrets.ACR_NAME }}
68-
azure-aca-client-id: ${{ secrets.ACA_CLIENT_ID }}
69-
azure-aca-name: ${{ secrets.ACA_CONTAINERAPP_NAME }}
70-
azure-aca-resource-group: ${{ secrets.ACA_RESOURCE_GROUP }}
7193

72-
build-import-deploy-app:
94+
deploy:
95+
name: Deploy
96+
needs: [ set-env, import ]
7397
permissions:
7498
id-token: write
75-
contents: read
76-
packages: write
77-
name: Build, import and deploy App Container
78-
needs: [ build-import-init-container ]
79-
uses: DFE-Digital/deploy-azure-container-apps-action/.github/workflows/build-push-deploy.yml@v3.1.0
99+
uses: DFE-Digital/deploy-azure-container-apps-action/.github/workflows/deploy.yml@v4.1.0
80100
with:
81-
docker-image-name: tramsapi-app
82-
docker-build-target: final
83101
environment: ${{ needs.set-env.outputs.environment }}
102+
docker-image-name: ${{ needs.set-env.outputs.image-name }}
84103
annotate-release: true
85-
docker-build-args: |
86-
COMMIT_SHA="${{ needs.set-env.outputs.checked-out-sha }}"
87-
CI=true
88104
secrets:
89105
azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
90106
azure-subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
91-
azure-acr-client-id: ${{ secrets.ACR_CLIENT_ID }}
92-
azure-acr-name: ${{ secrets.ACR_NAME }}
93107
azure-aca-client-id: ${{ secrets.ACA_CLIENT_ID }}
94108
azure-aca-name: ${{ secrets.ACA_CONTAINERAPP_NAME }}
95109
azure-aca-resource-group: ${{ secrets.ACA_RESOURCE_GROUP }}
110+
azure-acr-name: ${{ secrets.ACR_NAME }}
96111

97112
create-tag:
98113
name: Tag and release
99-
needs: [ set-env, build-import-deploy-app ]
114+
needs: [ set-env, deploy ]
100115
runs-on: ubuntu-24.04
101116
steps:
102117
- uses: actions/checkout@v4
@@ -147,7 +162,7 @@ jobs:
147162
148163
cypress-tests:
149164
name: Run Cypress Tests
150-
needs: [ set-env, create-tag ]
165+
needs: [ set-env, deploy ]
151166
if: needs.set-env.outputs.environment == 'test' || needs.set-env.outputs.environment == 'development'
152167
uses: ./.github/workflows/cypress-tests.yml
153168
with:

0 commit comments

Comments
 (0)