Skip to content

Commit e9ef9a7

Browse files
authored
Merge pull request #28 from guerreror58/footer-fixes
Fixed footer issues.
2 parents 0ae2e8e + 3caac46 commit e9ef9a7

File tree

2 files changed

+54
-11
lines changed

2 files changed

+54
-11
lines changed

app/components/Footer.tsx

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,19 @@
11
const Footer = () => {
22
return (
3-
<footer className="footer bg-neutral text-neutral-content items-center p-4">
4-
<aside className="grid-flow-col items-center">
5-
<img src="/images/logo.jpeg" className="w-8 rounded" />
6-
<p>© Copyright {new Date().getFullYear()}. All rights reserved</p>
3+
<footer className="footer flex justify-between bg-neutral text-neutral-content p-4">
4+
<aside className="flex devx-logo-copyright">
5+
<img src="/images/logo.jpeg" className="w-8 rounded mr-2" />
6+
<p className="flex items-center">
7+
© Copyright {new Date().getFullYear()}. All rights reserved
8+
</p>
79
</aside>
8-
<nav className="grid-flow-col gap-4 md:place-self-center md:justify-self-end">
9-
<a href="https://www.youtube.com/@sddevx" aria-label="Youtube">
10+
<nav className="flex">
11+
<a
12+
href="https://www.youtube.com/@sddevx"
13+
aria-label="Youtube"
14+
className="mr-4"
15+
target="_blank"
16+
>
1017
<svg
1118
xmlns="http://www.w3.org/2000/svg"
1219
width="24"
@@ -18,7 +25,7 @@ const Footer = () => {
1825
</svg>
1926
</a>
2027

21-
<a href="https://lu.ma/DEVxSD" aria-label="Luma">
28+
<a href="https://lu.ma/DEVxSD" aria-label="Luma" className="mr-4" target="_blank">
2229
<svg
2330
xmlns="http://www.w3.org/2000/svg"
2431
fill="none"
@@ -34,7 +41,12 @@ const Footer = () => {
3441
</svg>
3542
</a>
3643

37-
<a href="https://www.meetup.com/san-diego-devx/" aria-label="Meetup">
44+
<a
45+
href="https://www.meetup.com/san-diego-devx/"
46+
aria-label="Meetup"
47+
className="mr-4"
48+
target="_blank"
49+
>
3850
<svg
3951
xmlns="http://www.w3.org/2000/svg"
4052
width="24"
@@ -49,7 +61,12 @@ const Footer = () => {
4961
</svg>
5062
</a>
5163

52-
<a href="https://discord.gg/J3YrrErwjc" aria-label="Discord" className="mt-[-3px]">
64+
<a
65+
href="https://discord.gg/J3YrrErwjc"
66+
aria-label="Discord"
67+
className="mr-4"
68+
target="_blank"
69+
>
5370
<svg xmlns="http://www.w3.org/2000/svg" width="30" height="30" viewBox="0 0 24 24">
5471
<path
5572
fill="currentColor"
@@ -58,7 +75,7 @@ const Footer = () => {
5875
</svg>
5976
</a>
6077

61-
<a href="https://github.com/sddevx" aria-label="Github" className="mt-[-1px]">
78+
<a href="https://github.com/sddevx" aria-label="Github" target="_blank">
6279
<svg xmlns="http://www.w3.org/2000/svg" width="28" height="28" viewBox="0 0 24 24">
6380
<path
6481
fill="currentColor"

app/globals.css

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,32 @@ main {
2323
flex: 1;
2424
}
2525

26-
footer {
26+
.footer {
27+
column-gap: unset;
28+
row-gap: unset;
29+
line-height: unset;
30+
flex-direction: column-reverse;
31+
place-items: unset;
2732
position: relative;
33+
grid-auto-flow: unset;
34+
width: unset;
2835
}
36+
37+
.devx-logo-copyright {
38+
margin-top: 2.313rem;
39+
}
40+
41+
.footer > * {
42+
place-items: center;
43+
gap: unset;
44+
}
45+
46+
@media (min-width: 768px) {
47+
.footer {
48+
flex-direction: row;
49+
}
50+
51+
.devx-logo-copyright {
52+
margin-top: 0;
53+
}
54+
}

0 commit comments

Comments
 (0)