Merge pull request #135 from Cysharp/feature/FixMemoryLeakOnError

mayuki · web-flow · commit 829dac61aeb5 · 2025-05-13T15:47:22.000+09:00
Release a string when a request results in an error
diff --git a/src/YetAnotherHttpHandler/NativeHttpHandlerCore.cs b/src/YetAnotherHttpHandler/NativeHttpHandlerCore.cs
@@ -592,7 +592,7 @@ private static unsafe void OnComplete(int reqSeq, IntPtr state, CompletionReason
                         {
                             requestContext.CompleteAsFailed(UnsafeUtilities.GetStringFromUtf8Bytes(buf->AsSpan()), h2ErrorCode);
                         }
-                        catch
+                        finally
                         {
                             NativeMethods.yaha_free_byte_buffer(buf);
                         }

Original file line number	Diff line number	Diff line change
`@@ -592,7 +592,7 @@ private static unsafe void OnComplete(int reqSeq, IntPtr state, CompletionReason`
`592`	`592`	`{`
`593`	`593`	`requestContext.CompleteAsFailed(UnsafeUtilities.GetStringFromUtf8Bytes(buf->AsSpan()), h2ErrorCode);`
`594`	`594`	`}`
`595`		`- catch`
	`595`	`+ finally`
`596`	`596`	`{`
`597`	`597`	`NativeMethods.yaha_free_byte_buffer(buf);`
`598`	`598`	`}`