Skip to content

Bug provider APIs are not all wrapped through the approval #874

@0xisk

Description

@0xisk

How to reproduce?

  1. I changed the demo to have a button for directly calling one of the exposed RPC like GET_CONNECTED_IDENTITY_DATA through calling client.getConnectedIdentity()
  2. I did step (1) without going trough client.connect() which has the approval step.
  3. I did get output showing the connected identity metadata.

How to resolve?

I think all the exposed APIs should be handling the Approval part internally inside the background script. Which means that all the RPC calls inside the Provider are protected from inside the extension.

  • Screenshot of the button Get Connected Identity
    Image

  • Screenshot of the output data after clicking on Get Connected Identity
    Image

### Tasks
- [ ] https://github.com/CryptKeeperZK/crypt-keeper-extension/issues/897
- [ ] https://github.com/CryptKeeperZK/crypt-keeper-extension/issues/898
- [ ] https://github.com/CryptKeeperZK/crypt-keeper-extension/issues/899
- [ ] https://github.com/CryptKeeperZK/crypt-keeper-extension/issues/900
- [ ] https://github.com/CryptKeeperZK/crypt-keeper-extension/issues/932

Metadata

Metadata

Assignees

Labels

🪲 bugSomething isn't working

Type

No type

Projects

Status

👀 Review / QA

Relationships

None yet

Development

No branches or pull requests

Issue actions