Everything is underlined in diff view

[fr-joseph]

Hello!

How can I get rid of the excess underlines in the diff view? What am I doing wrong?

It happens in both diff variants (color words and git diff).
I've tried on X and Wayland.
I've tried different terminal emulators (foot, kitty, wezterm, alacritty).
I've tried with a few different fonts.

Thank you!

[istudyatuni]

Could you share your jj config? I have this in mine

[colors]
# do not underline lines in hunks (since 0.19)
"diff removed token" = { underline = false }
"diff added token" = { underline = false }

and lazyjj doesn't underline in diff, but if I comment these lines out, behavior the same as on your screenshot

upd. Okay, jj doesn't underline without this, strange

[fr-joseph]

@istudyatuni , adding the [colors] config fixed it. Thank you!

Feel free to close this.

[istudyatuni]

Feel free to close this.

I can't, but you can because you are the author of the issue

[fr-joseph]

Hmm, I changed my mind. I'm not really satisfied with disabling all the underlines. Is it possible to replicate the way that plain jj underlines the diff view?

The underlines are very useful for when spaces get added or removed. Hopefully this new example makes it easier to see, where the indentation changes after adding the surrounding if block.

[Cretezy]

I can replicate this as well. I have found the issue (reset bug in ansi-to-tui) and opened a PR: ratatui/ansi-to-tui#57

[Cretezy]

Fixed in v0.5.0 using fork (but not in cargo version)