Skip to content

Commit f5a2110

Browse files
committed
Update comments on stripping
1 parent d7906b3 commit f5a2110

File tree

6 files changed

+5
-14
lines changed

6 files changed

+5
-14
lines changed

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,10 @@ build-rust-debug:
4444
make update-bindings
4545

4646
# use release build to actually ship - smaller and much faster
47-
#
48-
# See https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-880616953 for two approaches to
49-
# enable stripping through cargo (if that is desired).
5047
build-rust-release:
5148
(cd libwasmvm && cargo build --release)
5249
cp libwasmvm/target/release/$(SHARED_LIB_SRC) internal/api/$(SHARED_LIB_DST)
5350
make update-bindings
54-
@ #this pulls out ELF symbols, 80% size reduction!
5551

5652
build-go:
5753
go build ./...

builders/guest/build_gnu_aarch64.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ set -o errexit -o nounset -o pipefail
33

44
export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
55

6-
# See https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-880616953 for two approaches to
7-
# enable stripping through cargo (if that is desired).
6+
# No stripping implemented (see https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-2260007943).
87

98
echo "Starting aarch64-unknown-linux-gnu build"
109
export CC=clang

builders/guest/build_gnu_x86_64.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ set -o errexit -o nounset -o pipefail
33

44
export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
55

6-
# See https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-880616953 for two approaches to
7-
# enable stripping through cargo (if that is desired).
6+
# No stripping implemented (see https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-2260007943).
87

98
echo "Starting x86_64-unknown-linux-gnu build"
109
export CC=clang

builders/guest/build_macos.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
77
export PATH="/opt/osxcross/target/bin:$PATH"
88
export LIBZ_SYS_STATIC=1
99

10-
# See https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-880616953 for two approaches to
11-
# enable stripping through cargo (if that is desired).
10+
# No stripping implemented (see https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-2260007943).
1211

1312
echo "Starting aarch64-apple-darwin build"
1413
export CC=aarch64-apple-darwin20.4-clang

builders/guest/build_macos_static.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
77
export PATH="/opt/osxcross/target/bin:$PATH"
88
export LIBZ_SYS_STATIC=1
99

10-
# See https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-880616953 for two approaches to
11-
# enable stripping through cargo (if that is desired).
10+
# No stripping implemented (see https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-2260007943).
1211

1312
echo "Starting aarch64-apple-darwin build"
1413
export CC=aarch64-apple-darwin20.4-clang

builders/guest/build_muslc.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ set -e # Note we are not using bash here but the Alpine default shell
33

44
export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
55

6-
# See https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-880616953 for two approaches to
7-
# enable stripping through cargo (if that is desired).
6+
# No stripping implemented (see https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-2260007943).
87

98
echo "Starting aarch64-unknown-linux-musl build"
109
export CC=/opt/aarch64-linux-musl-cross/bin/aarch64-linux-musl-gcc

0 commit comments

Comments
 (0)