Skip to content

Commit f3df522

Browse files
committed
Update calling convention of builders to 0100
1 parent 23be57a commit f3df522

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,34 +69,34 @@ bench:
6969
# Creates a release build in a containerized build environment of the static library for Alpine Linux (.a)
7070
release-build-alpine:
7171
# build the muslc *.a file
72-
docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-alpine
72+
docker run --rm -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-alpine
7373
cp libwasmvm/artifacts/libwasmvm_muslc.x86_64.a internal/api
7474
cp libwasmvm/artifacts/libwasmvm_muslc.aarch64.a internal/api
7575
make update-bindings
7676

7777
# Creates a release build in a containerized build environment of the shared library for glibc Linux (.so)
7878
release-build-linux:
79-
docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-debian build_gnu_x86_64.sh
80-
docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-debian build_gnu_aarch64.sh
79+
docker run --rm -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-debian build_gnu_x86_64.sh
80+
docker run --rm -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-debian build_gnu_aarch64.sh
8181
cp libwasmvm/artifacts/libwasmvm.x86_64.so internal/api
8282
cp libwasmvm/artifacts/libwasmvm.aarch64.so internal/api
8383
make update-bindings
8484

8585
# Creates a release build in a containerized build environment of the shared library for macOS (.dylib)
8686
release-build-macos:
87-
docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_macos.sh
87+
docker run --rm -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_macos.sh
8888
cp libwasmvm/artifacts/libwasmvm.dylib internal/api
8989
make update-bindings
9090

9191
# Creates a release build in a containerized build environment of the static library for macOS (.a)
9292
release-build-macos-static:
93-
docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_macos_static.sh
93+
docker run --rm -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_macos_static.sh
9494
cp libwasmvm/artifacts/libwasmvmstatic_darwin.a internal/api/libwasmvmstatic_darwin.a
9595
make update-bindings
9696

9797
# Creates a release build in a containerized build environment of the shared library for Windows (.dll)
9898
release-build-windows:
99-
docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_windows.sh
99+
docker run --rm -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_windows.sh
100100
cp libwasmvm/artifacts/wasmvm.dll internal/api
101101
make update-bindings
102102

builders/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,13 @@ See those DockerHub repos for all available versions of the builder images.
2828
- Rename builder image from cosmwasm/go-ext-builder to
2929
cosmwasm/libwasmvm-builder
3030
- Replace CentOS with Debian image for GNU linux builds
31+
- Avoid using a target folder in the host system. Instead the folder /target in
32+
the guest is used. Due to this change we can now drop the argument
33+
`-u $(USER_ID):$(USER_GROUP)` when using builders. ([#437])
3134
- Build all images with `--platform=linux/amd64` to avoid accidental ARM builds
3235

36+
[#437]: https://github.com/CosmWasm/wasmvm/issues/437
37+
3338
**Version 0019:**
3439

3540
- Bump `OSX_VERSION_MIN` to 10.15.

0 commit comments

Comments
 (0)