Skip to content

Commit b12bab6

Browse files
committed
Fix tests
1 parent 61b6bcd commit b12bab6

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

internal/api/lib_test.go

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package api
22

33
import (
4+
"bytes"
45
"crypto/sha256"
56
"encoding/hex"
67
"encoding/json"
@@ -409,14 +410,11 @@ func TestGetPinnedMetrics(t *testing.T) {
409410
err = Pin(cache, cyberpunkChecksum)
410411
require.NoError(t, err)
411412

412-
checksumStr := types.Checksum(checksum).String()
413-
cyberpunkChecksumStr := types.Checksum(cyberpunkChecksum).String()
414-
415-
findMetrics := func(list []types.PerModuleEntry, checksum string) *types.PerModuleMetrics {
413+
findMetrics := func(list []types.PerModuleEntry, checksum types.Checksum) *types.PerModuleMetrics {
416414
found := (*types.PerModuleMetrics)(nil)
417415

418416
for _, structure := range list {
419-
if structure.Checksum == checksum {
417+
if bytes.Equal(structure.Checksum, checksum) {
420418
found = &structure.Metrics
421419
break
422420
}
@@ -430,8 +428,8 @@ func TestGetPinnedMetrics(t *testing.T) {
430428
require.NoError(t, err)
431429
assert.Equal(t, 2, len(metrics.PerModule))
432430

433-
hackatomMetrics := findMetrics(metrics.PerModule, checksumStr)
434-
cyberpunkMetrics := findMetrics(metrics.PerModule, cyberpunkChecksumStr)
431+
hackatomMetrics := findMetrics(metrics.PerModule, checksum)
432+
cyberpunkMetrics := findMetrics(metrics.PerModule, cyberpunkChecksum)
435433

436434
assert.Equal(t, uint32(0), hackatomMetrics.Hits)
437435
assert.NotEqual(t, uint32(0), hackatomMetrics.Size)
@@ -455,8 +453,8 @@ func TestGetPinnedMetrics(t *testing.T) {
455453
require.NoError(t, err)
456454
assert.Equal(t, 2, len(metrics.PerModule))
457455

458-
hackatomMetrics = findMetrics(metrics.PerModule, checksumStr)
459-
cyberpunkMetrics = findMetrics(metrics.PerModule, cyberpunkChecksumStr)
456+
hackatomMetrics = findMetrics(metrics.PerModule, checksum)
457+
cyberpunkMetrics = findMetrics(metrics.PerModule, cyberpunkChecksum)
460458

461459
assert.Equal(t, uint32(1), hackatomMetrics.Hits)
462460
assert.NotEqual(t, uint32(0), hackatomMetrics.Size)

types/types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ type PerModuleMetrics struct {
197197
}
198198

199199
type PerModuleEntry struct {
200-
Checksum Checksum
201-
Metrics PerModuleMetrics
200+
Checksum Checksum
201+
Metrics PerModuleMetrics
202202
}
203203

204204
type PinnedMetrics struct {

0 commit comments

Comments
 (0)