Let builders target /target

Author: webmaster128

Makefile

@@ -68,9 +68,6 @@ bench:
 
 # Creates a release build in a containerized build environment of the static library for Alpine Linux (.a)
 release-build-alpine:
-	# Builders should not write their target folder into the host file system (https://github.com/CosmWasm/wasmvm/issues/437)
-	rm -rf libwasmvm/target/aarch64-unknown-linux-musl/release
-	rm -rf libwasmvm/target/x86_64-unknown-linux-musl/release
 	# build the muslc *.a file
 	docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-alpine
 	cp libwasmvm/artifacts/libwasmvm_muslc.x86_64.a internal/api
@@ -79,9 +76,6 @@ release-build-alpine:
 
 # Creates a release build in a containerized build environment of the shared library for glibc Linux (.so)
 release-build-linux:
-	# Builders should not write their target folder into the host file system (https://github.com/CosmWasm/wasmvm/issues/437)
-	rm -rf libwasmvm/target/x86_64-unknown-linux-gnu/release
-	rm -rf libwasmvm/target/aarch64-unknown-linux-gnu/release
 	docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-debian build_gnu_x86_64.sh
 	docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-debian build_gnu_aarch64.sh
 	cp libwasmvm/artifacts/libwasmvm.x86_64.so internal/api
@@ -90,28 +84,20 @@ release-build-linux:
 
 # Creates a release build in a containerized build environment of the shared library for macOS (.dylib)
 release-build-macos:
-	# Builders should not write their target folder into the host file system (https://github.com/CosmWasm/wasmvm/issues/437)
-	rm -rf libwasmvm/target/x86_64-apple-darwin/release
-	rm -rf libwasmvm/target/aarch64-apple-darwin/release
 	docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_macos.sh
 	cp libwasmvm/artifacts/libwasmvm.dylib internal/api
 	make update-bindings
 
 # Creates a release build in a containerized build environment of the static library for macOS (.a)
 release-build-macos-static:
-	# Builders should not write their target folder into the host file system (https://github.com/CosmWasm/wasmvm/issues/437)
-	rm -rf libwasmvm/target/x86_64-apple-darwin/release
-	rm -rf libwasmvm/target/aarch64-apple-darwin/release
 	docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_macos_static.sh
 	cp libwasmvm/artifacts/libwasmvmstatic_darwin.a internal/api/libwasmvmstatic_darwin.a
 	make update-bindings
 
 # Creates a release build in a containerized build environment of the shared library for Windows (.dll)
 release-build-windows:
-	# Builders should not write their target folder into the host file system (https://github.com/CosmWasm/wasmvm/issues/437)
-	rm -rf libwasmvm/target/x86_64-pc-windows-gnu/release
 	docker run --rm -u $(USER_ID):$(USER_GROUP) -v $(shell pwd)/libwasmvm:/code $(BUILDERS_PREFIX)-cross build_windows.sh
-	cp libwasmvm/target/x86_64-pc-windows-gnu/release/wasmvm.dll internal/api
+	cp libwasmvm/artifacts/wasmvm.dll internal/api
 	make update-bindings
 
 update-bindings:

builders/guest/build_gnu_aarch64.sh

@@ -2,6 +2,7 @@
 set -o errexit -o nounset -o pipefail
 
 export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
+export TARGET_DIR="/target" # write to /target in the guest's file system to avoid writing to the host
 
 # No stripping implemented (see https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-2260007943).
 
@@ -14,5 +15,5 @@ export AR_aarch64_unknown_linux_gnu=llvm-ar
 export CFLAGS_aarch64_unknown_linux_gnu="--sysroot=/usr/aarch64-linux-gnu"
 export CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=aarch64-linux-gnu-gcc
 export CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_RUNNER="$qemu_aarch64"
-cargo build --release --target aarch64-unknown-linux-gnu
-cp target/aarch64-unknown-linux-gnu/release/libwasmvm.so artifacts/libwasmvm.aarch64.so
+cargo build --release --target-dir="$TARGET_DIR" --target aarch64-unknown-linux-gnu
+cp "$TARGET_DIR/aarch64-unknown-linux-gnu/release/libwasmvm.so" artifacts/libwasmvm.aarch64.so

builders/guest/build_gnu_x86_64.sh

@@ -2,11 +2,12 @@
 set -o errexit -o nounset -o pipefail
 
 export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
+export TARGET_DIR="/target" # write to /target in the guest's file system to avoid writing to the host
 
 # No stripping implemented (see https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-2260007943).
 
 echo "Starting x86_64-unknown-linux-gnu build"
 export CC=clang
 export CXX=clang++
-cargo build --release --target x86_64-unknown-linux-gnu
-cp target/x86_64-unknown-linux-gnu/release/libwasmvm.so artifacts/libwasmvm.x86_64.so
+cargo build --release --target-dir="$TARGET_DIR" --target x86_64-unknown-linux-gnu
+cp "$TARGET_DIR/x86_64-unknown-linux-gnu/release/libwasmvm.so" artifacts/libwasmvm.x86_64.so

builders/guest/build_macos.sh

@@ -2,6 +2,7 @@
 set -o errexit -o nounset -o pipefail
 
 export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
+export TARGET_DIR="/target" # write to /target in the guest's file system to avoid writing to the host
 
 # ref: https://wapl.es/rust/2019/02/17/rust-cross-compile-linux-to-macos.html
 export PATH="/opt/osxcross/target/bin:$PATH"
@@ -12,14 +13,14 @@ export LIBZ_SYS_STATIC=1
 echo "Starting aarch64-apple-darwin build"
 export CC=aarch64-apple-darwin20.4-clang
 export CXX=aarch64-apple-darwin20.4-clang++
-cargo build --release --target aarch64-apple-darwin
+cargo build --release --target-dir="$TARGET_DIR" --target aarch64-apple-darwin
 
 echo "Starting x86_64-apple-darwin build"
 export CC=o64-clang
 export CXX=o64-clang++
-cargo build --release --target x86_64-apple-darwin
+cargo build --release --target-dir="$TARGET_DIR" --target x86_64-apple-darwin
 
 # Create a universal library with both archs
 lipo -output artifacts/libwasmvm.dylib -create \
-  target/x86_64-apple-darwin/release/deps/libwasmvm.dylib \
-  target/aarch64-apple-darwin/release/deps/libwasmvm.dylib
+  "$TARGET_DIR/x86_64-apple-darwin/release/deps/libwasmvm.dylib" \
+  "$TARGET_DIR/aarch64-apple-darwin/release/deps/libwasmvm.dylib"

builders/guest/build_macos_static.sh

@@ -2,6 +2,7 @@
 set -o errexit -o nounset -o pipefail
 
 export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
+export TARGET_DIR="/target" # write to /target in the guest's file system to avoid writing to the host
 
 # ref: https://wapl.es/rust/2019/02/17/rust-cross-compile-linux-to-macos.html
 export PATH="/opt/osxcross/target/bin:$PATH"
@@ -12,14 +13,14 @@ export LIBZ_SYS_STATIC=1
 echo "Starting aarch64-apple-darwin build"
 export CC=aarch64-apple-darwin20.4-clang
 export CXX=aarch64-apple-darwin20.4-clang++
-cargo build --release --target aarch64-apple-darwin --example wasmvmstatic
+cargo build --release --target-dir="$TARGET_DIR" --target aarch64-apple-darwin --example wasmvmstatic
 
 echo "Starting x86_64-apple-darwin build"
 export CC=o64-clang
 export CXX=o64-clang++
-cargo build --release --target x86_64-apple-darwin --example wasmvmstatic
+cargo build --release --target-dir="$TARGET_DIR" --target x86_64-apple-darwin --example wasmvmstatic
 
 # Create a universal library with both archs
 lipo -output artifacts/libwasmvmstatic_darwin.a -create \
-  target/x86_64-apple-darwin/release/examples/libwasmvmstatic.a \
-  target/aarch64-apple-darwin/release/examples/libwasmvmstatic.a
+  "$TARGET_DIR/x86_64-apple-darwin/release/examples/libwasmvmstatic.a" \
+  "$TARGET_DIR/aarch64-apple-darwin/release/examples/libwasmvmstatic.a"

builders/guest/build_muslc.sh

@@ -2,16 +2,17 @@
 set -e # Note we are not using bash here but the Alpine default shell
 
 export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
+export TARGET_DIR="/target" # write to /target in the guest's file system to avoid writing to the host
 
 # No stripping implemented (see https://github.com/CosmWasm/wasmvm/issues/222#issuecomment-2260007943).
 
 echo "Starting aarch64-unknown-linux-musl build"
 export CC=/opt/aarch64-linux-musl-cross/bin/aarch64-linux-musl-gcc
-cargo build --release --target aarch64-unknown-linux-musl --example wasmvmstatic
+cargo build --release --target-dir="$TARGET_DIR" --target aarch64-unknown-linux-musl --example wasmvmstatic
 unset CC
 
 echo "Starting x86_64-unknown-linux-musl build"
-cargo build --release --target x86_64-unknown-linux-musl --example wasmvmstatic
+cargo build --release --target-dir="$TARGET_DIR" --target x86_64-unknown-linux-musl --example wasmvmstatic
 
-cp target/aarch64-unknown-linux-musl/release/examples/libwasmvmstatic.a artifacts/libwasmvm_muslc.aarch64.a
-cp target/x86_64-unknown-linux-musl/release/examples/libwasmvmstatic.a artifacts/libwasmvm_muslc.x86_64.a
+cp "$TARGET_DIR/aarch64-unknown-linux-musl/release/examples/libwasmvmstatic.a" artifacts/libwasmvm_muslc.aarch64.a
+cp "$TARGET_DIR/x86_64-unknown-linux-musl/release/examples/libwasmvmstatic.a" artifacts/libwasmvm_muslc.x86_64.a

builders/guest/build_windows.sh

@@ -2,7 +2,10 @@
 set -o errexit -o nounset -o pipefail
 
 export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
+export TARGET_DIR="/target" # write to /target in the guest's file system to avoid writing to the host
 
 # ref: https://www.reddit.com/r/rust/comments/5k8uab/crosscompiling_from_ubuntu_to_windows_with_rustup/
 
-cargo build --release --target x86_64-pc-windows-gnu
+cargo build --release --target-dir="$TARGET_DIR" --target x86_64-pc-windows-gnu
+
+cp "$TARGET_DIR/x86_64-pc-windows-gnu/release/wasmvm.dll" artifacts/wasmvm.dll