Skip to content

Commit 716bfbf

Browse files
committed
Address review
1 parent 6ee8a4a commit 716bfbf

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

packages/vm/Cargo.toml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ iterator = ["cosmwasm-std/iterator"]
1818
staking = ["cosmwasm-std/staking"]
1919
# this enables all stargate-related functionality, including the ibc entry points
2020
stargate = ["cosmwasm-std/stargate"]
21-
# Use cranelift backend instead of singlepass. This is required for development on Windows.
22-
#
23-
# Note: This feature is automatically enabled on Windows, you don't have to toggle it manually anymore.
24-
# This is just to be able to debug issues with Cranelift on non-Windows platforms.
21+
# Use cranelift backend instead of singlepass
2522
cranelift = ["wasmer/cranelift"]
2623
# For heap profiling. Only used in the "heap_profiling" example.
2724
dhat-heap = ["dep:dhat"]
@@ -62,9 +59,6 @@ tracing = "0.1.32"
6259
# wasmer = { path = "../../../wasmer/lib/api", default-features = false, features = ["cranelift", "singlepass"] }
6360
# wasmer-middlewares = { path = "../../../wasmer/lib/middlewares" }
6461

65-
[target.'cfg(target_family = "windows")'.dependencies]
66-
wasmer = { version = "=4.2.6", default-features = false, features = ["cranelift"] }
67-
6862
[dev-dependencies]
6963
criterion = { version = "0.5.1", features = ["html_reports"] }
7064
glob = "0.3.1"

packages/vm/src/wasm_backend/engine.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ fn cost(_operator: &Operator) -> u64 {
2626
150
2727
}
2828

29-
/// Creates the appropriate compiler config for the platform
29+
/// Use Cranelift as the compiler backend if the feature is enabled
3030
pub fn make_compiler_config() -> impl CompilerConfig + Into<Engine> {
31-
#[cfg(any(feature = "cranelift", target_family = "windows"))]
31+
#[cfg(feature = "cranelift")]
3232
return wasmer::Cranelift::new();
33-
#[cfg(not(any(feature = "cranelift", target_family = "windows")))]
33+
#[cfg(not(feature = "cranelift"))]
3434
wasmer::Singlepass::new()
3535
}
3636

0 commit comments

Comments
 (0)