@@ -103,7 +103,9 @@ fn ecdsa_secp256k1_sha256() {
103
103
let valid = secp256k1_verify ( & message_hash, & signature, & public_key) . unwrap ( ) ;
104
104
assert ! ( valid) ;
105
105
if tc. comment == "k*G has a large x-coordinate" {
106
- // this case is currently not supported for historic reasons
106
+ // This case (recovery ID 2 and 3) was never supported in the implementation of
107
+ // secp256k1_recover_pubkey because the library we used at that time did not support it.
108
+ // If needed, we could enable it now in a consensus breaking change.
107
109
} else {
108
110
test_recover_pubkey ( & message_hash, & signature, & public_key, [ 0 , 1 ] ) ;
109
111
}
@@ -153,7 +155,9 @@ fn ecdsa_secp256k1_sha512() {
153
155
let valid = secp256k1_verify ( & message_hash, & signature, & public_key) . unwrap ( ) ;
154
156
assert ! ( valid) ;
155
157
if tc. comment == "k*G has a large x-coordinate" {
156
- // this case is currently not supported for historic reasons
158
+ // This case (recovery ID 2 and 3) was never supported in the implementation of
159
+ // secp256k1_recover_pubkey because the library we used at that time did not support it.
160
+ // If needed, we could enable it now in a consensus breaking change.
157
161
} else {
158
162
test_recover_pubkey ( & message_hash, & signature, & public_key, [ 0 , 1 ] ) ;
159
163
}
@@ -203,7 +207,9 @@ fn ecdsa_secp256k1_sha3_256() {
203
207
let valid = secp256k1_verify ( & message_hash, & signature, & public_key) . unwrap ( ) ;
204
208
assert ! ( valid) ;
205
209
if tc. comment == "k*G has a large x-coordinate" {
206
- // this case is currently not supported for historic reasons
210
+ // This case (recovery ID 2 and 3) was never supported in the implementation of
211
+ // secp256k1_recover_pubkey because the library we used at that time did not support it.
212
+ // If needed, we could enable it now in a consensus breaking change.
207
213
} else {
208
214
test_recover_pubkey ( & message_hash, & signature, & public_key, [ 0 , 1 ] ) ;
209
215
}
@@ -253,7 +259,9 @@ fn ecdsa_secp256k1_sha3_512() {
253
259
let valid = secp256k1_verify ( & message_hash, & signature, & public_key) . unwrap ( ) ;
254
260
assert ! ( valid) ;
255
261
if tc. comment == "k*G has a large x-coordinate" {
256
- // this case is currently not supported for historic reasons
262
+ // This case (recovery ID 2 and 3) was never supported in the implementation of
263
+ // secp256k1_recover_pubkey because the library we used at that time did not support it.
264
+ // If needed, we could enable it now in a consensus breaking change.
257
265
} else {
258
266
test_recover_pubkey ( & message_hash, & signature, & public_key, [ 0 , 1 ] ) ;
259
267
}
0 commit comments