Skip to content

Commit 08e953c

Browse files
committed
Add comment about reference types to Gatekeeper
1 parent 0b0e170 commit 08e953c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/vm/src/wasm_backend/gatekeeper.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ impl Default for Gatekeeper {
6363
Self::new(GatekeeperConfig {
6464
allow_floats: true,
6565
allow_feature_bulk_memory_operations: false,
66+
// we allow the reference types proposal during compatibility checking because a subset
67+
// of it is required since Rust 1.82, but we don't allow any of the instructions specific
68+
// to the proposal here. Especially `table.grow` and `table.fill` can be abused to cause
69+
// very long runtime and high memory usage.
6670
allow_feature_reference_types: false,
6771
allow_feature_simd: false,
6872
allow_feature_exception_handling: false,

0 commit comments

Comments
 (0)