Skip to content

Increase SERVER_API_ROUTES_TIMEOUT_MS #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
FriendlyTroll opened this issue Mar 20, 2025 · 1 comment
Open
3 tasks done

Increase SERVER_API_ROUTES_TIMEOUT_MS #407

FriendlyTroll opened this issue Mar 20, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@FriendlyTroll
Copy link

What type of request is this?

Enhancement of an existing feature

Clear and concise description of the feature you are proposing

Firstly, thanks for the great app!

I recommend to increase the timeout mentioned above. The reasoning is that IMHO, 5s is too short when uploading files even 2-3 MB large, it really depends on the upload speed of the client, especially considering that the payload is set to 52MB right now, I would expect to upload bigger files with no issues. Now you get an error like
{"level":30,"time":1742465810762,"pid":1,"hostname":"fd17aa60b497","namespace":"app","status":504,"method":"POST","path":"/api/notes","routePath":"/api/notes","durationMs":5001,"msg":"Request completed"}

I believe it would be better for UX to have this raised to something like 20-30s by default. It's not a big deal as one can easily customize it via env variable, but just a thought!

Additional context

No response

Validations

  • Check the feature is not already implemented in the project.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Check that the feature is technically feasible and aligns with the project's goals.
@FriendlyTroll FriendlyTroll added the enhancement New feature or request label Mar 20, 2025
@18c83fd3-25ea-4ed9-8205-2abeff9b3883

Increased the default API route timeout from 5 seconds to 30 seconds by modifying the routeTimeoutMs default value in the server configuration. Created PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants