Fix notebook magic tests for environments without IPython/ipywidgets

- Add comprehensive placeholder classes and functions when IPython unavailable
- Include display, HTML, and complete widgets module mock classes
- Update test fixtures to use setattr() instead of patching non-existent attributes
- Fix magic method tests to work regardless of IPython availability in test environment
- Remove redundant display() patching that was causing AttributeError
- All 279 tests now pass including previously failing notebook magic tests

Resolves GitHub Actions test failures in environments with different IPython configurations.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: jeremymanning

clustrix/notebook_magic.py

@@ -30,10 +30,66 @@ def magics_class(cls):
 
     def cell_magic(name):
         def decorator(func):
+            # When IPython isn't available, return the original function unchanged
             return func
 
         return decorator
 
+    def display(*args, **kwargs):
+        """Placeholder display function."""
+        pass
+
+    class HTML:  # type: ignore
+        """Placeholder HTML class."""
+
+        def __init__(self, *args, **kwargs):
+            pass
+
+    # Mock widgets module
+    class widgets:  # type: ignore
+        class Dropdown:
+            def __init__(self, *args, **kwargs):
+                pass
+
+        class Button:
+            def __init__(self, *args, **kwargs):
+                pass
+
+        class Text:
+            def __init__(self, *args, **kwargs):
+                pass
+
+        class IntText:
+            def __init__(self, *args, **kwargs):
+                pass
+
+        class Textarea:
+            def __init__(self, *args, **kwargs):
+                pass
+
+        class Output:
+            def __init__(self, *args, **kwargs):
+                pass
+
+            def clear_output(self, *args, **kwargs):
+                pass
+
+        class VBox:
+            def __init__(self, *args, **kwargs):
+                pass
+
+        class HBox:
+            def __init__(self, *args, **kwargs):
+                pass
+
+        class HTML:
+            def __init__(self, *args, **kwargs):
+                pass
+
+        class Layout:
+            def __init__(self, *args, **kwargs):
+                pass
+
 
 from .config import configure, get_config
 

tests/test_notebook_magic.py

@@ -87,9 +87,11 @@ def mock_ipython(self):
             # Set the widgets attribute on the module
             setattr(clustrix.notebook_magic, "widgets", mock_widgets)
 
-            with patch("clustrix.notebook_magic.display") as mock_display:
-                mock_display.return_value = None
-                yield
+            # Mock display function
+            mock_display = MagicMock()
+            setattr(clustrix.notebook_magic, "display", mock_display)
+
+            yield
 
     def test_widget_initialization(self, mock_ipython):
         """Test widget initialization with defaults."""
@@ -364,11 +366,11 @@ class TestClusterfyMagics:
 
     def test_magic_without_ipython(self):
         """Test magic command fails gracefully without IPython."""
+        # Patch the IPYTHON_AVAILABLE check directly in the method
         with patch("clustrix.notebook_magic.IPYTHON_AVAILABLE", False):
-            # Create a simple mock without trying to use the Magics base class
-            mock_shell = MagicMock()
-            magic = ClusterfyMagics.__new__(ClusterfyMagics)  # Create without __init__
-            magic.shell = mock_shell
+            # Create magic instance properly
+            magic = ClusterfyMagics()
+            magic.shell = MagicMock()
 
             # Should print error message
             with patch("builtins.print") as mock_print:
@@ -382,31 +384,29 @@ def test_magic_with_ipython(self):
         """Test magic command creates widget with IPython."""
         with patch("clustrix.notebook_magic.IPYTHON_AVAILABLE", True):
             with patch("clustrix.notebook_magic.ClusterConfigWidget") as MockWidget:
-                with patch("clustrix.notebook_magic.display"):
-                    magic = ClusterfyMagics()
-                    magic.shell = MagicMock()
+                magic = ClusterfyMagics()
+                magic.shell = MagicMock()
 
-                    # Call magic
-                    magic.clusterfy("", "")
+                # Call magic
+                magic.clusterfy("", "")
 
-                    # Check widget was created and displayed
-                    MockWidget.assert_called_once()
-                    MockWidget.return_value.display.assert_called_once()
+                # Check widget was created and displayed
+                MockWidget.assert_called_once()
+                MockWidget.return_value.display.assert_called_once()
 
     def test_magic_executes_cell_code(self):
         """Test magic command executes code in cell."""
         with patch("clustrix.notebook_magic.IPYTHON_AVAILABLE", True):
             with patch("clustrix.notebook_magic.ClusterConfigWidget"):
-                with patch("clustrix.notebook_magic.display"):
-                    magic = ClusterfyMagics()
-                    magic.shell = MagicMock()
+                magic = ClusterfyMagics()
+                magic.shell = MagicMock()
 
-                    # Call magic with code
-                    test_code = "x = 42"
-                    magic.clusterfy("", test_code)
+                # Call magic with code
+                test_code = "x = 42"
+                magic.clusterfy("", test_code)
 
-                    # Check code was executed
-                    magic.shell.run_cell.assert_called_once_with(test_code)
+                # Check code was executed
+                magic.shell.run_cell.assert_called_once_with(test_code)
 
 
 class TestIPythonExtension: