Skip to content

Commit 7e0650e

Browse files
jeremymanningclaude
andcommitted
Final formatting fixes after re-running all checks
- Re-ran black formatter after flake8 fixes reformatted 3 test files - Verified flake8 still passes with no errors after black reformatting - All 223 tests continue to pass - Documentation builds with fewer warnings (19 vs 36) - All essential checks now passing cleanly Final status: ✅ Black formatting: Clean ✅ Flake8 linting: Clean ✅ All tests: 223 passing ✅ Documentation: Builds successfully 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent c639936 commit 7e0650e

File tree

6 files changed

+16
-8
lines changed

6 files changed

+16
-8
lines changed
89 Bytes
Binary file not shown.

docs/build/html/searchindex.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

notes/all_checks_status.csv

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Check Type,Command,Expected Result,Current Status,Notes/Commit Hash
2-
Black formatter,black clustrix/,No changes needed,complete,1 file reformatted (config.py)
3-
Black formatter tests,black tests/,No changes needed,complete,1 file reformatted (test_kubernetes_integration.py)
4-
Flake8 linter clustrix,flake8 clustrix/,No errors,complete,No errors found
5-
Flake8 linter tests,flake8 tests/,No errors,complete,Fixed 31 errors (unused imports and lambda assignments)
2+
Black formatter,black clustrix/,No changes needed,complete,No changes needed after re-run
3+
Black formatter tests,black tests/,No changes needed,complete,3 files reformatted after flake8 fixes
4+
Flake8 linter clustrix,flake8 clustrix/,No errors,complete,No errors found after re-run
5+
Flake8 linter tests,flake8 tests/,No errors,complete,No errors found after re-run
66
Type checking,mypy clustrix/,No errors (if configured),blocked,45 errors found - extensive type annotation work needed
7-
All tests,pytest,All tests pass,complete,223 tests passed
8-
Documentation build,cd docs && make html,Docs build successfully,complete,Built with 36 warnings (mostly missing pages)
7+
All tests,pytest,All tests pass,complete,223 tests passed after re-run
8+
Documentation build,cd docs && make html,Docs build successfully,complete,Built with 19 warnings (down from 36)

tests/test_executor.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,9 @@ def mock_execute_command(cmd):
180180

181181
# Verify sbatch command was executed
182182
execute_calls = executor._execute_remote_command.call_args_list
183-
sbatch_calls = [call_obj for call_obj in execute_calls if "sbatch" in str(call_obj)]
183+
sbatch_calls = [
184+
call_obj for call_obj in execute_calls if "sbatch" in str(call_obj)
185+
]
184186
assert len(sbatch_calls) > 0
185187

186188
@patch("os.unlink")
@@ -463,6 +465,7 @@ def mock_get(remote_path, local_path):
463465
assert call_args[0] == "/tmp/test_job/result.pkl" # remote path
464466
# Verify local path is a temporary file (cross-platform)
465467
import tempfile
468+
466469
temp_dir = tempfile.gettempdir()
467470
assert call_args[1].startswith(temp_dir) # local temp path
468471

tests/test_local_executor.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import time
33
import multiprocessing as mp
44
from concurrent.futures import ThreadPoolExecutor, ProcessPoolExecutor
5+
56
# Removed unused unittest.mock imports
67

78
from clustrix.local_executor import (
@@ -257,6 +258,7 @@ def test_safe_pickle_test_success(self):
257258

258259
def test_safe_pickle_test_failure(self):
259260
"""Test pickle test with unpicklable objects."""
261+
260262
# Lambda functions are not picklable
261263
def lambda_func(x):
262264
return x
@@ -266,6 +268,7 @@ def lambda_func(x):
266268

267269
def unpicklable_func(x):
268270
return x + y
271+
269272
assert _safe_pickle_test(unpicklable_func) is False
270273

271274
# File objects are not picklable
@@ -279,6 +282,7 @@ def test_choose_executor_type_unpicklable_function(self):
279282

280283
def unpicklable_func(x):
281284
return x + y
285+
282286
result = choose_executor_type(unpicklable_func, (), {})
283287
assert result is True # Should use threads
284288

tests/test_loop_analysis.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ def function_without_loops():
140140

141141
def test_detect_loops_source_unavailable(self):
142142
"""Test loop detection when source code is unavailable."""
143+
143144
# Lambda functions don't have accessible source code
144145
def no_source_func():
145146
return sum(range(10))

0 commit comments

Comments
 (0)