Fixing unset intro

Author: devinmatte

conditional/blueprints/slideshow.py

@@ -12,7 +12,7 @@
 from conditional.util.auth import get_user
 from conditional.util.flask import render_template
 from conditional.util.ldap import ldap_is_eval_director, ldap_is_intromember, ldap_set_failed, ldap_set_bad_standing, \
-    ldap_set_intro_member, ldap_set_inactive, ldap_get_member
+    ldap_set_inactive, ldap_get_member, ldap_set_not_intro_member
 
 logger = structlog.get_logger()
 
@@ -135,7 +135,7 @@ def slideshow_spring_review(user_dict=None):
 
     if status == "Passed":
         if ldap_is_intromember(account):
-            ldap_set_intro_member(account)
+            ldap_set_not_intro_member(account)
     elif status == "Failed":
         if ldap_is_intromember(account):
             ldap_set_failed(account)

conditional/util/ldap.py

@@ -132,6 +132,12 @@ def ldap_set_intro_member(account):
     ldap_get_member.cache_clear()
 
 
+def ldap_set_not_intro_member(account):
+    _ldap_remove_member_from_group(account, 'intromembers')
+    ldap_get_intro_members().cache_clear()
+    ldap_get_member.cache_clear()
+
+
 def ldap_set_current_student(account):
     _ldap_add_member_to_group(account, 'current_student')
     ldap_get_current_students.cache_clear()