Skip to content

Commit 912e046

Browse files
authored
Merge pull request #181 from devinmatte/develop
Fixing Attendance issue and Style Changes
2 parents 2dc389a + 6235eb3 commit 912e046

File tree

6 files changed

+24
-7
lines changed

6 files changed

+24
-7
lines changed

conditional/blueprints/attendance.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def display_attendance_cm(user_dict=None):
137137
log.info('Display Committee Meeting Attendance Page')
138138

139139
return render_template('attendance_cm.html',
140-
username=request.headers.get("x-webauth-user"),
140+
username=user_dict['username'],
141141
date=datetime.now().strftime("%Y-%m-%d"))
142142

143143

@@ -149,7 +149,7 @@ def display_attendance_ts(user_dict=None):
149149
log.info('Display Technical Seminar Attendance Page')
150150

151151
return render_template('attendance_ts.html',
152-
username=request.headers.get("x-webauth-user"),
152+
username=user_dict['username'],
153153
date=datetime.now().strftime("%Y-%m-%d"))
154154

155155

conditional/templates/dashboard.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ <h3 class="panel-title">Directorship Meeting Attendance</h3>
352352
{% for meeting in cm_attendance %}
353353
<tr>
354354
<td>{{meeting['committee']}}</td>
355-
<td>{{meeting['timestamp']}}</td>
355+
<td>{{meeting['timestamp'].strftime('%Y-%m-%d')}}</td>
356356
</tr>
357357
{% endfor %}
358358
</tbody>

conditional/templates/intro_eval_slideshow.html

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,13 @@ <h3>{{m['technical_seminars']|length}}</h3>
4747
</div>
4848
</div>
4949
</div>
50-
<h4><span class="icon glyphicon glyphicon-{% if m['freshman_project'] == 'Passed' %}ok passed{%else%}remove{% endif %}" aria-hidden="true"></span> Freshman Project</h4>
51-
50+
51+
<h4>
52+
{% if m['freshman_project'] != 'Pending' %}
53+
<span class="icon glyphicon glyphicon-{% if m['freshman_project'] == 'Passed' %}ok passed{%else%}remove{% endif %}" aria-hidden="true"></span> Freshman Project
54+
{% endif %}
55+
</h4>
56+
5257
<div class="actions" data-uid="{{m['uid']}}" data-cn="{{m['name']}}">
5358
<button class="pass" type="button">Pass</button>
5459
<button class="fail" type="button">Fail</button>

conditional/templates/intro_evals.html

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,11 @@ <h6 class="eval-uid">{{ m['uid'] }}</h6>
124124
</div>
125125
</div>
126126
{% if m['house_meetings_missed']|length != 0 or m['technical_seminars']|length != 0 or m['comments'] != "" %}
127-
<button class="btn-expand-panel" role="button" data-toggle="collapse" href="#evalsCollapse-{{m['uid']}}" aria-expanded="false" aria-controls="evalsCollapse-{{m['uid']}}"><span class="glyphicon glyphicon glyphicon-menu-down"></span></button>
127+
<div class="evals-dropdown">
128+
<span class="btn-expand-panel" role="button" data-toggle="collapse" href="#evalsCollapse-{{m['uid']}}" aria-expanded="false" aria-controls="evalsCollapse-{{m['uid']}}">
129+
<span class="glyphicon glyphicon glyphicon-menu-down"></span>
130+
</span>
131+
</div>
128132
{% endif %}
129133
<div class="collapse" id="evalsCollapse-{{m['uid']}}">
130134
{% if m['house_meetings_missed']|length > 0 %}

conditional/templates/spring_evals.html

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,11 @@ <h6 class="eval-uid">{{m['uid']}}</h6>
9393
</div>
9494

9595
{% if m['house_meetings_missed']|length > 0 or m['major_projects_len'] > 0 %}
96-
<button class="btn-expand-panel" role="button" data-toggle="collapse" href="#evalsCollapse{{m['uid']}}" aria-expanded="false" aria-controls="evalsCollapse{{m['uid']}}"><span class="glyphicon glyphicon glyphicon-menu-down"></span></button>
96+
<div class="evals-dropdown">
97+
<span class="btn-expand-panel" role="button" data-toggle="collapse" href="#evalsCollapse{{m['uid']}}" aria-expanded="false" aria-controls="evalsCollapse{{m['uid']}}">
98+
<span class="glyphicon glyphicon glyphicon-menu-down"></span>
99+
</span>
100+
</div>
97101
{% endif %}
98102
<div class="collapse" id="evalsCollapse{{m['uid']}}">
99103
{% if m['house_meetings_missed']|length > 0 %}

frontend/stylesheets/pages/_evals.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,3 +72,7 @@
7272
box-shadow: none;
7373
padding: 3px 7px;
7474
}
75+
76+
.evals-dropdown {
77+
text-align: center;
78+
}

0 commit comments

Comments
 (0)