Skip to content

Commit 59f3fa4

Browse files
committed
Removing obvious references to freshmen project
1 parent 2530625 commit 59f3fa4

File tree

5 files changed

+0
-92
lines changed

5 files changed

+0
-92
lines changed

conditional/blueprints/intro_evals.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ def get_fid_cm_count(member_id):
8888
))
8989
],
9090
'social_events': '',
91-
'freshman_project': "Pending",
9291
'comments': "",
9392
'ldap_account': False,
9493
'status': "Pending"
@@ -141,14 +140,12 @@ def get_fid_cm_count(member_id):
141140
TechnicalSeminar.approved == True # pylint: disable=singleton-comparison
142141
).all()],
143142
'social_events': freshman_data.social_events,
144-
'freshman_project': freshman_data.freshman_project,
145143
'comments': freshman_data.other_notes,
146144
'ldap_account': True,
147145
'status': freshman_data.freshman_eval_result
148146
}
149147
ie_members.append(member_info)
150148

151-
ie_members.sort(key=lambda x: x['freshman_project'] == "Passed")
152149
ie_members.sort(key=lambda x: len(x['house_meetings_missed']))
153150
ie_members.sort(key=lambda x: x['committee_meetings'], reverse=True)
154151
ie_members.sort(key=lambda x: x['signatures_missed'])

conditional/blueprints/member_management.py

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -530,57 +530,6 @@ def member_management_make_user_active(user_dict=None):
530530
return jsonify({"success": True}), 200
531531

532532

533-
@member_management_bp.route('/manage/intro_project', methods=['GET'])
534-
@auth.oidc_auth
535-
@get_user
536-
def introductory_project(user_dict=None):
537-
log = logger.new(request=request, auth_dict=user_dict)
538-
log.info('Display Freshmen Project Management')
539-
540-
if not ldap_is_eval_director(user_dict['account']):
541-
return "must be eval director", 403
542-
543-
return render_template('introductory_project.html',
544-
username=user_dict['username'],
545-
intro_members=display_intro_evals(internal=True))
546-
547-
548-
@member_management_bp.route('/manage/intro_project', methods=['POST'])
549-
@auth.oidc_auth
550-
@get_user
551-
def introductory_project_submit(user_dict=None):
552-
log = logger.new(request=request, auth_dict=user_dict)
553-
554-
if not ldap_is_eval_director(user_dict['account']):
555-
return "must be eval director", 403
556-
557-
post_data = request.get_json()
558-
559-
if not isinstance(post_data, list):
560-
abort(400)
561-
562-
for intro_member in post_data:
563-
if not isinstance(intro_member, dict):
564-
abort(400)
565-
566-
if 'uid' not in intro_member or 'status' not in intro_member:
567-
abort(400)
568-
569-
if intro_member['status'] not in ['Passed', 'Pending', 'Failed']:
570-
abort(400)
571-
572-
log.info('Freshmen Project {} for {}'.format(intro_member['status'], intro_member['uid']))
573-
574-
FreshmanEvalData.query.filter(FreshmanEvalData.uid == intro_member['uid']).update({
575-
'freshman_project': intro_member['status']
576-
})
577-
578-
db.session.flush()
579-
db.session.commit()
580-
581-
return jsonify({"success": True}), 200
582-
583-
584533
@member_management_bp.route('/member/<uid>', methods=['GET'])
585534
@auth.oidc_auth
586535
@get_user

conditional/models/models.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ class FreshmanEvalData(db.Model):
3030
__tablename__ = 'freshman_eval_data'
3131
id = Column(Integer, primary_key=True)
3232
uid = Column(String(32), nullable=False)
33-
freshman_project = Column(Enum('Pending', 'Passed', 'Failed',
34-
name="freshman_project_enum"), nullable=False)
3533
eval_date = Column(DateTime, nullable=False)
3634
signatures_missed = Column(Integer, nullable=False)
3735
social_events = Column(Text)
@@ -42,7 +40,6 @@ class FreshmanEvalData(db.Model):
4240

4341
def __init__(self, uid, signatures_missed):
4442
self.uid = uid
45-
self.freshman_project = 'Pending'
4643
self.freshman_eval_result = 'Pending'
4744
self.signatures_missed = signatures_missed
4845
self.social_events = ""

conditional/templates/intro_eval_slideshow.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,6 @@ <h3>{{m['technical_seminars']|length}}</h3>
4949
</div>
5050
</div>
5151

52-
<h4>
53-
{% if m['freshman_project'] != 'Pending' %}
54-
<span class="icon glyphicon glyphicon-{% if m['freshman_project'] == 'Passed' %}ok passed{%else%}remove{% endif %}" aria-hidden="true"></span> Freshman Project
55-
{% endif %}
56-
</h4>
57-
5852
<div class="actions" data-uid="{{m['uid']}}" data-cn="{{m['name']}}">
5953
<button class="pass" type="button">Pass</button>
6054
<button class="fail" type="button">Fail</button>

conditional/templates/intro_evals.html

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -86,25 +86,6 @@ <h6 class="eval-uid">{{ m['uid'] }}</h6>
8686
</div>
8787
{% endif %}
8888

89-
</div>
90-
<div class="text-center">
91-
{% if m['freshman_project'] == "Passed" %}
92-
<div class="eval-info-label">
93-
<span class="glyphicon glyphicon-ok-sign green eval-info-status"></span>Freshmen Project
94-
<span class="eval-info-number">Passed</span>
95-
</div>
96-
{% elif m['freshman_project'] == "Failed" %}
97-
<div class="eval-info-label">
98-
<span class="glyphicon glyphicon-remove-sign red eval-info-status"></span>Freshmen Project
99-
<span class="eval-info-number">Failed</span>
100-
</div>
101-
{% else %}
102-
<div class="eval-info-label">
103-
<span class="glyphicon glyphicon-hourglass yellow eval-info-status"></span>Freshmen Project
104-
<span class="eval-info-number">Pending</span>
105-
</div>
106-
{% endif %}
107-
10889
</div>
10990
<div class="text-center">
11091
{% if m['house_meetings_missed']|length > 0 %}
@@ -203,7 +184,6 @@ <h4>Other Comments</h4>
203184
<th>Result</th>
204185
<th>Meetings</th>
205186
<th>Signatures Missed</th>
206-
<th>Freshman Project</th>
207187
<th>Technical Seminars</th>
208188
<th>House Meetings Missed</th>
209189
</tr>
@@ -239,15 +219,6 @@ <h4>Other Comments</h4>
239219
<span class="glyphicon glyphicon-hourglass yellow eval-info-status"></span> Pending
240220
{% endif %}
241221
</td>
242-
<td>
243-
{% if m['freshman_project'] == "Passed" %}
244-
<span class="glyphicon glyphicon-ok-sign green eval-info-status"></span> Passed
245-
{% elif m['freshman_project'] == "Failed" %}
246-
<span class="glyphicon glyphicon-remove-sign red eval-info-status"></span> Failed
247-
{% else %}
248-
<span class="glyphicon glyphicon-hourglass yellow eval-info-status"></span> Pending
249-
{% endif %}
250-
</td>
251222
<td data-sort="{{ m['technical_seminars']|length }}">
252223
{% if m['technical_seminars']|length >= 2 %}
253224
<span class="glyphicon glyphicon-ok-sign green eval-info-status"></span> {{m['technical_seminars']|length}}

0 commit comments

Comments
 (0)