Skip to content

Commit 44fd202

Browse files
authored
Merge pull request #25 from ComputerScienceHouse/develop
Fixes
2 parents b3d388a + b38b0fb commit 44fd202

File tree

2 files changed

+10
-13
lines changed

2 files changed

+10
-13
lines changed

frontend/javascript/modules/editUser.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@ export default class EditUser {
178178

179179
// Freshman Name
180180
modal.querySelector('input[name=name]').value = this.data.name;
181-
modal.querySelector('input[name=name]').disabled = true;
182181

183182
// Room Number
184183
modal.querySelector('input[name=room]').value = this.data.room_number;

frontend/javascript/modules/table.js

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,28 @@ export default class Table {
77
this.table = table;
88

99
// Set options based on data attributes
10-
this.paginated = !(this.table.dataset.paginated === 'false');
1110
this.sortColumn = (_.isNil(this.table.dataset.sortColumn) ||
1211
_.isNaN(this.table.dataset.sortColumn)) ?
1312
1 : this.table.dataset.sortColumn;
1413
this.sortOrder = this.table.dataset.sortOrder === "asc" ? "asc" : "desc";
15-
this.lengthChangable = this.table.dataset.lengthChangable === 'true';
14+
15+
this.options = {
16+
lengthChange: this.table.dataset.lengthChangable === 'true',
17+
info: false,
18+
paging: !(this.table.dataset.paginated === 'false'),
19+
pagingType: "numbers"
20+
};
1621

1722
// Just remove the search input from the DOM instead of disabling it
18-
this.domOptions = "lrtip";
19-
if (this.table.dataset.searchable === 'true') {
20-
this.domOptions = "lfrtip";
23+
if (this.table.dataset.searchable !== 'true') {
24+
this.options.dom = "lrtip";
2125
}
2226

2327
this.render();
2428
}
2529

2630
render() {
27-
this.table = $(this.table).DataTable({ // eslint-disable-line new-cap
28-
// dom: this.domOptions,
29-
lengthChange: this.lengthChangable,
30-
info: false,
31-
paging: this.paginated,
32-
pagingType: "numbers"
33-
})
31+
this.table = $(this.table).DataTable(this.options) // eslint-disable-line new-cap
3432
.order([this.sortColumn, this.sortOrder])
3533
.draw();
3634
}

0 commit comments

Comments
 (0)