Skip to content

Commit 1e3c485

Browse files
RamZallanliam-middlebrook
authored andcommitted
Hide non-approved meetings and seminars from slideshows
1 parent 9bcbf06 commit 1e3c485

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

conditional/blueprints/intro_evals.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
from conditional.models.models import FreshmanCommitteeAttendance
1111
from conditional.models.models import MemberCommitteeAttendance
12+
from conditional.models.models import CommitteeMeeting
1213
from conditional.models.models import FreshmanAccount
1314
from conditional.models.models import FreshmanEvalData
1415
from conditional.models.models import FreshmanHouseMeetingAttendance
@@ -33,11 +34,13 @@ def display_intro_evals(internal=False):
3334
# get user data
3435
def get_uid_cm_count(member_id):
3536
return len([a for a in MemberCommitteeAttendance.query.filter(
36-
MemberCommitteeAttendance.uid == member_id)])
37+
MemberCommitteeAttendance.uid == member_id)
38+
if CommitteeMeeting.query.filter(CommitteeMeeting.id == a.meeting_id).approved])
3739

3840
def get_fid_cm_count(member_id):
3941
return len([a for a in FreshmanCommitteeAttendance.query.filter(
40-
FreshmanCommitteeAttendance.fid == member_id)])
42+
FreshmanCommitteeAttendance.fid == member_id)
43+
if CommitteeMeeting.query.filter(CommitteeMeeting.id == a.meeting_id).approved])
4144

4245
user_name = None
4346
if not internal:
@@ -88,7 +91,8 @@ def get_fid_cm_count(member_id):
8891
[s.name for s in TechnicalSeminar.query.filter(
8992
TechnicalSeminar.id.in_(
9093
[a.seminar_id for a in FreshmanSeminarAttendance.query.filter(
91-
FreshmanSeminarAttendance.fid == fid.id)]
94+
FreshmanSeminarAttendance.fid == fid.id)
95+
if TechnicalSeminar.query.filter(TechnicalSeminar.id == a.seminar_id).approved]
9296
))
9397
],
9498
'social_events': '',
@@ -141,7 +145,8 @@ def get_fid_cm_count(member_id):
141145
[s.name for s in TechnicalSeminar.query.filter(
142146
TechnicalSeminar.id.in_(
143147
[a.seminar_id for a in MemberSeminarAttendance.query.filter(
144-
MemberSeminarAttendance.uid == uid)]
148+
MemberSeminarAttendance.uid == uid)
149+
if TechnicalSeminar.query.filter(TechnicalSeminar.id == a.seminar_id).approved]
145150
))
146151
],
147152
'social_events': freshman_data.social_events,

conditional/blueprints/spring_evals.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from conditional.util.ldap import ldap_get_active_members
77

88
from conditional.models.models import MemberCommitteeAttendance
9+
from conditional.models.models import CommitteeMeeting
910
from conditional.models.models import MemberHouseMeetingAttendance
1011
from conditional.models.models import MajorProject
1112
from conditional.models.models import HouseMeeting
@@ -28,7 +29,8 @@ def display_spring_evals(internal=False):
2829

2930
def get_cm_count(member_id):
3031
return len([a for a in MemberCommitteeAttendance.query.filter(
31-
MemberCommitteeAttendance.uid == member_id)])
32+
MemberCommitteeAttendance.uid == member_id)
33+
if CommitteeMeeting.query.filter(CommitteeMeeting.id == a.meeting_id).approved])
3234

3335
user_name = None
3436
if not internal:

0 commit comments

Comments
 (0)