Switch to target-type new() for direct return values

Author: Sergio0694

CommunityToolkit.Diagnostics/Extensions/ValueTypeExtensions.cs

@@ -63,6 +63,6 @@ public static unsafe string ToHexString<T>(this T value)
             p[j] = (char)Unsafe.Add(ref rh, high);
         }
 
-        return new string(p, 0, bufferSize);
+        return new(p, 0, bufferSize);
     }
 }

CommunityToolkit.HighPerformance/Buffers/ArrayPoolBufferWriter{T}.cs

@@ -325,7 +325,7 @@ public override string ToString()
         if (typeof(T) == typeof(char) &&
             this.array is char[] chars)
         {
-            return new string(chars, 0, this.index);
+            return new(chars, 0, this.index);
         }
 
         // Same representation used in Span<T>

CommunityToolkit.HighPerformance/Buffers/Internals/ArrayMemoryManager{TFrom,TTo}.cs

@@ -86,7 +86,7 @@ public override unsafe MemoryHandle Pin(int elementIndex = 0)
         ref byte r2 = ref Unsafe.Add(ref r1, byteOffset);
         void* pi = Unsafe.AsPointer(ref r2);
 
-        return new MemoryHandle(pi, handle);
+        return new(pi, handle);
     }
 
     /// <inheritdoc/>

CommunityToolkit.HighPerformance/Buffers/Internals/RawObjectMemoryManager{T}.cs

@@ -72,7 +72,7 @@ public override unsafe MemoryHandle Pin(int elementIndex = 0)
         ref T r1 = ref Unsafe.Add(ref r0, (nint)(uint)elementIndex);
         void* p = Unsafe.AsPointer(ref r1);
 
-        return new MemoryHandle(p, handle);
+        return new(p, handle);
     }
 
     /// <inheritdoc/>

CommunityToolkit.HighPerformance/Buffers/Internals/StringMemoryManager{TTo}.cs

@@ -82,7 +82,7 @@ public override unsafe MemoryHandle Pin(int elementIndex = 0)
         ref byte r2 = ref Unsafe.Add(ref r1, byteOffset);
         void* pi = Unsafe.AsPointer(ref r2);
 
-        return new MemoryHandle(pi, handle);
+        return new(pi, handle);
     }
 
     /// <inheritdoc/>

CommunityToolkit.HighPerformance/Buffers/MemoryOwner{T}.cs

@@ -157,7 +157,7 @@ public Memory<T> Memory
                 ThrowObjectDisposedException();
             }
 
-            return new Memory<T>(array!, this.start, this.length);
+            return new(array!, this.start, this.length);
         }
     }
 
@@ -190,7 +190,7 @@ public Span<T> Span
             // especially if T is a value type, in which case the covariance check is JIT removed.
             return MemoryMarshal.CreateSpan(ref r0, this.length);
 #else
-            return new Span<T>(array!, this.start, this.length);
+            return new(array!, this.start, this.length);
 #endif
         }
     }
@@ -239,7 +239,7 @@ public ArraySegment<T> DangerousGetArray()
             ThrowObjectDisposedException();
         }
 
-        return new ArraySegment<T>(array!, this.start, this.length);
+        return new(array!, this.start, this.length);
     }
 
     /// <summary>
@@ -282,7 +282,7 @@ public MemoryOwner<T> Slice(int start, int length)
         // suppress the finalizer to reduce the overhead on the garbage collector.
         GC.SuppressFinalize(this);
 
-        return new MemoryOwner<T>(start, length, this.pool, array!);
+        return new(start, length, this.pool, array!);
     }
 
     /// <inheritdoc/>
@@ -312,7 +312,7 @@ public override string ToString()
         if (typeof(T) == typeof(char) &&
             this.array is char[] chars)
         {
-            return new string(chars, this.start, this.length);
+            return new(chars, this.start, this.length);
         }
 
         // Same representation used in Span<T>

CommunityToolkit.HighPerformance/Buffers/SpanOwner{T}.cs

@@ -146,7 +146,7 @@ public Span<T> Span
 
             return MemoryMarshal.CreateSpan(ref r0, this.length);
 #else
-            return new Span<T>(this.array, 0, this.length);
+            return new(this.array, 0, this.length);
 #endif
         }
     }
@@ -192,7 +192,7 @@ public override string ToString()
         if (typeof(T) == typeof(char) &&
             this.array is char[] chars)
         {
-            return new string(chars, 0, this.length);
+            return new(chars, 0, this.length);
         }
 
         // Same representation used in Span<T>

CommunityToolkit.HighPerformance/Enumerables/ReadOnlyRefEnumerable{T}.cs

@@ -98,7 +98,7 @@ public static ReadOnlyRefEnumerable<T> DangerousCreate(in T value, int length, i
 
         OverflowHelper.EnsureIsInNativeIntRange(length, 1, step);
 
-        return new ReadOnlyRefEnumerable<T>(in value, length, step);
+        return new(in value, length, step);
     }
 #else
     /// <summary>
@@ -182,9 +182,9 @@ public ref readonly T this[Index index]
     public Enumerator GetEnumerator()
     {
 #if NETSTANDARD2_1_OR_GREATER
-        return new Enumerator(this.span, this.step);
+        return new(this.span, this.step);
 #else
-        return new Enumerator(this.instance, this.offset, this.length, this.step);
+        return new(this.instance, this.offset, this.length, this.step);
 #endif
     }
 
@@ -342,9 +342,9 @@ public T[] ToArray()
     public static implicit operator ReadOnlyRefEnumerable<T>(RefEnumerable<T> enumerable)
     {
 #if NETSTANDARD2_1_OR_GREATER
-        return new ReadOnlyRefEnumerable<T>(enumerable.Span, enumerable.Step);
+        return new(enumerable.Span, enumerable.Step);
 #else
-        return new ReadOnlyRefEnumerable<T>(enumerable.Instance, enumerable.Offset, enumerable.Length, enumerable.Step);
+        return new(enumerable.Instance, enumerable.Offset, enumerable.Length, enumerable.Step);
 #endif
     }
 

CommunityToolkit.HighPerformance/Enumerables/ReadOnlySpanEnumerable{T}.cs

@@ -68,9 +68,9 @@ public readonly Item Current
             ref T ri = ref Unsafe.Add(ref r0, (nint)(uint)this.index);
 
             // See comment in SpanEnumerable<T> about this
-            return new Item(ref ri, this.index);
+            return new(ref ri, this.index);
 #else
-            return new Item(this.span, this.index);
+            return new(this.span, this.index);
 #endif
         }
     }

CommunityToolkit.HighPerformance/Enumerables/RefEnumerable{T}.cs

@@ -81,7 +81,7 @@ public static RefEnumerable<T> DangerousCreate(ref T value, int length, int step
 
         OverflowHelper.EnsureIsInNativeIntRange(length, 1, step);
 
-        return new RefEnumerable<T>(ref value, length, step);
+        return new(ref value, length, step);
     }
 #else
     /// <summary>
@@ -165,9 +165,9 @@ public ref T this[Index index]
     public Enumerator GetEnumerator()
     {
 #if NETSTANDARD2_1_OR_GREATER
-        return new Enumerator(this.Span, this.Step);
+        return new(this.Span, this.Step);
 #else
-        return new Enumerator(this.Instance, this.Offset, this.Length, this.Step);
+        return new(this.Instance, this.Offset, this.Length, this.Step);
 #endif
     }