Merge pull request #447 from Youssef1313/patch-1

Sergio0694 · web-flow · commit e6257d8c6512 · 2022-09-20T13:48:50.000-07:00
Replace characters from StringBuilder to reduce string allocations
diff --git a/CommunityToolkit.Mvvm.SourceGenerators/Extensions/INamedTypeSymbolExtensions.cs b/CommunityToolkit.Mvvm.SourceGenerators/Extensions/INamedTypeSymbolExtensions.cs
@@ -40,7 +40,7 @@ ITypeSymbol ts when ts.ContainingType is ISymbol pt
         // one to the outermost namespace, if any. Additionally, the ` and + symbols need to be replaced
         // to avoid errors when generating code. This is a known issue with source generators not accepting
         // those characters at the moment, see: https://github.com/dotnet/roslyn/issues/58476.
-        return BuildFrom(symbol, new StringBuilder(256)).ToString().Replace('`', '-').Replace('+', '.');
+        return BuildFrom(symbol, new StringBuilder(256)).Replace('`', '-').Replace('+', '.').ToString();
     }
 
     /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ ITypeSymbol ts when ts.ContainingType is ISymbol pt`
`40`	`40`	// one to the outermost namespace, if any. Additionally, the ` and + symbols need to be replaced
`41`	`41`	`// to avoid errors when generating code. This is a known issue with source generators not accepting`
`42`	`42`	`// those characters at the moment, see: https://github.com/dotnet/roslyn/issues/58476.`
`43`		- return BuildFrom(symbol, new StringBuilder(256)).ToString().Replace('`', '-').Replace('+', '.');
	`43`	+ return BuildFrom(symbol, new StringBuilder(256)).Replace('`', '-').Replace('+', '.').ToString();
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`/// <summary>`