Merge pull request #884 from arivoir/feature/881

Avoid auto-generating ObservableValidator.HasError

Author: Sergio0694

src/CommunityToolkit.Mvvm/ComponentModel/ObservableValidator.cs

@@ -123,6 +123,7 @@ protected ObservableValidator(ValidationContext validationContext)
     }
 
     /// <inheritdoc/>
+    [Display(AutoGenerateField = false)]
     public bool HasErrors => this.totalErrors > 0;
 
     /// <summary>

tests/CommunityToolkit.Mvvm.UnitTests/Test_ObservableValidator.cs

@@ -607,7 +607,20 @@ public void Test_ObservableValidator_ValidateAllProperties_IncludeInheritedPrope
         Assert.IsFalse(model.HasErrors);
         Assert.IsTrue(events.Count == 1);
 
-        Assert.IsTrue(events.Any(e => e.PropertyName == nameof(DerivedModelWithValidatableProperties.Name)));    }
+        Assert.IsTrue(events.Any(e => e.PropertyName == nameof(DerivedModelWithValidatableProperties.Name)));
+    }
+
+    // See https://github.com/CommunityToolkit/dotnet/issues/881
+    [TestMethod]
+    public void Test_ObservableValidator_HasErrors_IncludeNonAutogenerateAttribute()
+    {
+        DerivedModelWithValidatableProperties model = new();
+
+        DisplayAttribute? displayAttribute = model.GetType().GetProperty(nameof(ObservableValidator.HasErrors))?.GetCustomAttribute<DisplayAttribute>();
+
+        Assert.IsNotNull(displayAttribute);
+        Assert.IsFalse(displayAttribute.AutoGenerateField);
+    }
 
     public class Person : ObservableValidator
     {