Skip to content

Commit 78d37ab

Browse files
committed
Use specific reference assemblies to resolve test errors, mark fixer shared.
1 parent 441abbb commit 78d37ab

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/CommunityToolkit.Mvvm.Fixers/FieldReferenceForObservablePropertyFieldFixer.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// See the LICENSE file in the project root for more information.
44

55
using System.Collections.Immutable;
6+
using System.Composition;
67
using System.Diagnostics;
78
using System.Linq;
89
using System.Threading;
@@ -18,7 +19,7 @@
1819
namespace CommunityToolkit.Mvvm.Fixers;
1920

2021
#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
21-
[ExportCodeFixProvider(LanguageNames.CSharp)]
22+
[ExportCodeFixProvider(LanguageNames.CSharp), Shared]
2223
public class FieldReferenceForObservablePropertyFieldFixer : CodeFixProvider
2324
{
2425
public override ImmutableArray<string> FixableDiagnosticIds { get; } = ImmutableArray.Create(DiagnosticDescriptors.FieldReferenceForObservablePropertyFieldId);
@@ -60,7 +61,7 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
6061

6162
}
6263

63-
private async Task<Document> UpdateReference(Document document, IdentifierNameSyntax fieldReference, string propertyName, CancellationToken cancellationToken)
64+
private static async Task<Document> UpdateReference(Document document, IdentifierNameSyntax fieldReference, string propertyName, CancellationToken cancellationToken)
6465
{
6566
IdentifierNameSyntax propertyReference = SyntaxFactory.IdentifierName(propertyName);
6667
SyntaxNode originalRoot = await fieldReference.SyntaxTree.GetRootAsync(cancellationToken);

tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn401.UnitTests/Test_FieldReferenceForObservablePropertyFieldFixer.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ void M()
5858
{
5959
TestCode = original,
6060
FixedCode = @fixed,
61+
ReferenceAssemblies = ReferenceAssemblies.Net.Net60
6162
};
6263

6364
test.TestState.AdditionalReferences.Add(typeof(ObservableObject).Assembly);
@@ -119,6 +120,7 @@ void M()
119120
{
120121
TestCode = original,
121122
FixedCode = @fixed,
123+
ReferenceAssemblies = ReferenceAssemblies.Net.Net60
122124
};
123125

124126
test.TestState.AdditionalReferences.Add(typeof(ObservableObject).Assembly);
@@ -188,6 +190,7 @@ void M()
188190
{
189191
TestCode = original,
190192
FixedCode = @fixed,
193+
ReferenceAssemblies = ReferenceAssemblies.Net.Net60
191194
};
192195

193196
test.TestState.AdditionalReferences.Add(typeof(ObservableObject).Assembly);
@@ -255,6 +258,7 @@ void M()
255258
{
256259
TestCode = original,
257260
FixedCode = @fixed,
261+
ReferenceAssemblies = ReferenceAssemblies.Net.Net60
258262
};
259263

260264
test.TestState.AdditionalReferences.Add(typeof(ObservableObject).Assembly);

0 commit comments

Comments
 (0)