Rename fields still using _lowerCamelCase names

Author: Sergio0694

CommunityToolkit.Common/Deferred/DeferredEventArgs.cs

@@ -19,19 +19,19 @@ public class DeferredEventArgs : EventArgs
     /// </summary>
     public static new DeferredEventArgs Empty => new();
 
-    private readonly object _eventDeferralLock = new();
+    private readonly object eventDeferralLock = new();
 
-    private EventDeferral? _eventDeferral;
+    private EventDeferral? eventDeferral;
 
     /// <summary>
     /// Returns an <see cref="EventDeferral"/> which can be completed when deferred event is ready to continue.
     /// </summary>
     /// <returns><see cref="EventDeferral"/> instance.</returns>
     public EventDeferral GetDeferral()
     {
-        lock (this._eventDeferralLock)
+        lock (this.eventDeferralLock)
         {
-            return this._eventDeferral ??= new EventDeferral();
+            return this.eventDeferral ??= new EventDeferral();
         }
     }
 
@@ -45,11 +45,11 @@ public EventDeferral GetDeferral()
     [Obsolete("This is an internal only method to be used by EventHandler extension classes, public callers should call GetDeferral() instead.")]
     public EventDeferral? GetCurrentDeferralAndReset()
     {
-        lock (this._eventDeferralLock)
+        lock (this.eventDeferralLock)
         {
-            EventDeferral? eventDeferral = this._eventDeferral;
+            EventDeferral? eventDeferral = this.eventDeferral;
 
-            this._eventDeferral = null;
+            this.eventDeferral = null;
 
             return eventDeferral;
         }

CommunityToolkit.Common/Deferred/EventDeferral.cs

@@ -16,8 +16,8 @@ namespace CommunityToolkit.Common.Deferred;
 /// </summary>
 public class EventDeferral : IDisposable
 {
-    //// TODO: If/when .NET 6 is base, we can upgrade to non-generic version
-    private readonly TaskCompletionSource<object?> _taskCompletionSource = new();
+    // TODO: If/when .NET 6 is base, we can upgrade to non-generic version
+    private readonly TaskCompletionSource<object?> taskCompletionSource = new();
 
     internal EventDeferral()
     {
@@ -26,7 +26,7 @@ internal EventDeferral()
     /// <summary>
     /// Call when finished with the Deferral.
     /// </summary>
-    public void Complete() => this._taskCompletionSource.TrySetResult(null);
+    public void Complete() => this.taskCompletionSource.TrySetResult(null);
 
     /// <summary>
     /// Waits for the <see cref="EventDeferral"/> to be completed by the event handler.
@@ -38,9 +38,9 @@ internal EventDeferral()
     [Obsolete("This is an internal only method to be used by EventHandler extension classes, public callers should call GetDeferral() instead on the DeferredEventArgs.")]
     public async Task WaitForCompletion(CancellationToken cancellationToken)
     {
-        using (cancellationToken.Register(() => this._taskCompletionSource.TrySetCanceled()))
+        using (cancellationToken.Register(() => this.taskCompletionSource.TrySetCanceled()))
         {
-            _ = await this._taskCompletionSource.Task;
+            _ = await this.taskCompletionSource.Task;
         }
     }
 

CommunityToolkit.Mvvm/Messaging/Internals/System/Runtime.CompilerServices/ConditionalWeakTable2{TKey,TValue}.ZeroAlloc.cs

@@ -307,7 +307,7 @@ private sealed class Container
         private readonly ConditionalWeakTable2<TKey, TValue> parent;
 
         /// <summary>
-        /// <c>_buckets[hashcode &amp; (_buckets.Length - 1)]</c> contains index of the first entry in bucket (-1 if empty).
+        /// <c>buckets[hashcode &amp; (buckets.Length - 1)]</c> contains index of the first entry in bucket (-1 if empty).
         /// </summary>
         private int[] buckets;
 
@@ -317,7 +317,7 @@ private sealed class Container
         private Entry[] entries;
 
         /// <summary>
-        /// <c>_firstFreeEntry &lt; _entries.Length => table</c> has capacity, entries grow from the bottom of the table.
+        /// <c>firstFreeEntry &lt; entries.Length => table</c> has capacity, entries grow from the bottom of the table.
         /// </summary>
         private int firstFreeEntry;
 
@@ -410,7 +410,7 @@ internal void CreateEntryNoResize(TKey key, TValue value)
         }
 
         /// <summary>
-        /// Worker for finding a key/value pair. Must hold _lock.
+        /// Worker for finding a key/value pair. Must hold lock.
         /// </summary>
         internal bool TryGetValueWorker(TKey key, [MaybeNullWhen(false)] out TValue value)
         {
@@ -423,7 +423,7 @@ internal bool TryGetValueWorker(TKey key, [MaybeNullWhen(false)] out TValue valu
 
         /// <summary>
         /// Returns -1 if not found (if key expires during FindEntry, this can be treated as "not found.").
-        /// Must hold _lock, or be prepared to retry the search while holding _lock.
+        /// Must hold lock, or be prepared to retry the search while holding lock.
         /// </summary>
         /// <remarks>This method requires <paramref name="value"/> to be on the stack to be properly tracked.</remarks>
         internal int FindEntry(TKey key, out object? value)
@@ -463,7 +463,7 @@ internal bool TryGetEntry(int index, [NotNullWhen(true)] out TKey? key, [MaybeNu
         {
             if (index < this.entries.Length)
             {
-                // object? oKey = _entries[index].depHnd.UnsafeGetTargetAndDependent(out object? oValue);
+                // object? oKey = entries[index].depHnd.UnsafeGetTargetAndDependent(out object? oValue);
                 (object? oKey, object? oValue) = this.entries[index].depHnd.TargetAndDependent;
 
                 // Ensure we don't get finalized while accessing DependentHandle
@@ -522,10 +522,10 @@ private void RemoveIndex(int entryIndex)
         }
 
         /// <summary>
-        /// Resize, and scrub expired keys off bucket lists. Must hold _lock.
+        /// Resize, and scrub expired keys off bucket lists. Must hold <see cref="lockObject"/>.
         /// </summary>
         /// <remarks>
-        /// _firstEntry is less than _entries.Length on exit, that is, the table has at least one free entry.
+        /// <see cref="firstFreeEntry"/> is less than <c>entries.Length</c> on exit, that is, the table has at least one free entry.
         /// </remarks>
         internal Container Resize()
         {