Add tests for class-level attributes

Author: Sergio0694

tests/CommunityToolkit.Mvvm.SourceGenerators.UnitTests/Test_SourceGeneratorsDiagnostics.cs

@@ -1258,6 +1258,46 @@ public partial class SampleViewModel : ObservableValidator
         VerifyGeneratedDiagnostics<ObservablePropertyGenerator>(source, "MVVMTK0026");
     }
 
+    [TestMethod]
+    public void InvalidTypeForNotifyRecipientsError()
+    {
+        string source = @"
+            using CommunityToolkit.Mvvm.ComponentModel;
+
+            namespace MyApp
+            {
+                [NotifyRecipients]
+                public partial class MyViewModel : ObservableObject
+                {
+                    [ObservableProperty]
+                    public int number;
+                }
+            }";
+
+        VerifyGeneratedDiagnostics<ObservablePropertyGenerator>(source, "MVVMTK0027");
+    }
+
+    [TestMethod]
+    public void InvalidTypeForNotifyDataErrorInfoError()
+    {
+        string source = @"
+            using System.ComponentModel.DataAnnotations;
+            using CommunityToolkit.Mvvm.ComponentModel;
+
+            namespace MyApp
+            {
+                [NotifyDataErrorInfo]
+                public partial class SampleViewModel : ObservableObject
+                {
+                    [ObservableProperty]
+                    [Required]
+                    private string name;
+                }
+            }";
+
+        VerifyGeneratedDiagnostics<ObservablePropertyGenerator>(source, "MVVMTK0006", "MVVMTK0028");
+    }
+
     /// <summary>
     /// Verifies the output of a source generator.
     /// </summary>

tests/CommunityToolkit.Mvvm.UnitTests/Test_ObservablePropertyAttribute.cs

@@ -264,6 +264,32 @@ public void Test_ObservablePropertyWithValueNamedField_WithValidationAttributesA
         Assert.AreEqual(errors[1].PropertyName, nameof(ModelWithValuePropertyWithAutomaticValidation.Value));
     }
 
+    [TestMethod]
+    public void Test_ObservablePropertyWithValueNamedField_WithValidationAttributesAndValidation_WithClassLevelAttribute()
+    {
+        ModelWithValuePropertyWithAutomaticValidationWithClassLevelAttribute model = new();
+
+        List<string?> propertyNames = new();
+
+        model.PropertyChanged += (s, e) => propertyNames.Add(e.PropertyName);
+
+        List<DataErrorsChangedEventArgs> errors = new();
+
+        model.ErrorsChanged += (s, e) => errors.Add(e);
+
+        model.Value = "Bo";
+
+        Assert.IsTrue(model.HasErrors);
+        Assert.AreEqual(errors.Count, 1);
+        Assert.AreEqual(errors[0].PropertyName, nameof(ModelWithValuePropertyWithAutomaticValidationWithClassLevelAttribute.Value));
+
+        model.Value = "Hello world";
+
+        Assert.IsFalse(model.HasErrors);
+        Assert.AreEqual(errors.Count, 2);
+        Assert.AreEqual(errors[1].PropertyName, nameof(ModelWithValuePropertyWithAutomaticValidationWithClassLevelAttribute.Value));
+    }
+
     // See https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/4184
     [TestMethod]
     public void Test_GeneratedPropertiesWithValidationAttributesOverFields()
@@ -424,6 +450,33 @@ public void Test_NotifyRecipients_WithInheritedObservableRecipientAttribute()
             propertyName: nameof(BroadcastingViewModelWithInheritedAttribute.Name2));
     }
 
+    [TestMethod]
+    public void Test_NotifyRecipients_WithObservableObject_WithClassLevelAttribute()
+    {
+        Test_NotifyRecipients_Test(
+           factory: static messenger => new BroadcastingViewModelWithClassLevelAttribute(messenger),
+           setter: static (model, value) => model.Name = value,
+           propertyName: nameof(BroadcastingViewModelWithClassLevelAttribute.Name));
+    }
+
+    [TestMethod]
+    public void Test_NotifyRecipients_WithObservableRecipientAttribute_WithClassLevelAttribute()
+    {
+        Test_NotifyRecipients_Test(
+            factory: static messenger => new BroadcastingViewModelWithAttributeAndClassLevelAttribute(messenger),
+            setter: static (model, value) => model.Name = value,
+            propertyName: nameof(BroadcastingViewModelWithAttributeAndClassLevelAttribute.Name));
+    }
+
+    [TestMethod]
+    public void Test_NotifyRecipients_WithInheritedObservableRecipientAttribute_WithClassLevelAttribute()
+    {
+        Test_NotifyRecipients_Test(
+            factory: static messenger => new BroadcastingViewModelWithInheritedAttributeAndClassLevelAttribute(messenger),
+            setter: static (model, value) => model.Name2 = value,
+            propertyName: nameof(BroadcastingViewModelWithInheritedAttributeAndClassLevelAttribute.Name2));
+    }
+
     private void Test_NotifyRecipients_Test<T>(Func<IMessenger, T> factory, Action<T, string?> setter, string propertyName)
         where T : notnull
     {
@@ -452,6 +505,24 @@ private void Test_NotifyRecipients_Test<T>(Func<IMessenger, T> factory, Action<T
         Assert.AreEqual(propertyName, messages[0].Message.PropertyName);
     }
 
+    [TestMethod]
+    public void Test_ObservableProperty_ObservableRecipientDoesNotBroadcastByDefault()
+    {
+        IMessenger messenger = new StrongReferenceMessenger();
+        RecipientWithNonBroadcastingProperty model = new(messenger);
+
+        List<(object Sender, PropertyChangedMessage<string?> Message)> messages = new();
+
+        messenger.Register<PropertyChangedMessage<string?>>(model, (r, m) => messages.Add((r, m)));
+
+        model.Name = "Bob";
+        model.Name = "Alice";
+        model.Name = null;
+
+        // The [NotifyRecipients] attribute wasn't used, so no messages should have been sent
+        Assert.AreEqual(messages.Count, 0);
+    }
+
 #if NET6_0_OR_GREATER
     // See https://github.com/CommunityToolkit/dotnet/issues/155
     [TestMethod]
@@ -969,6 +1040,15 @@ public partial class ModelWithValuePropertyWithAutomaticValidation : ObservableV
         private string? value;
     }
 
+    [NotifyDataErrorInfo]
+    public partial class ModelWithValuePropertyWithAutomaticValidationWithClassLevelAttribute : ObservableValidator
+    {
+        [ObservableProperty]
+        [Required]
+        [MinLength(5)]
+        private string? value;
+    }
+
     public partial class ViewModelWithValidatableGeneratedProperties : ObservableValidator
     {
         [Required]
@@ -1080,6 +1160,17 @@ public BroadcastingViewModel(IMessenger messenger)
         private string? name;
     }
 
+    partial class RecipientWithNonBroadcastingProperty : ObservableRecipient
+    {
+        public RecipientWithNonBroadcastingProperty(IMessenger messenger)
+            : base(messenger)
+        {
+        }
+
+        [ObservableProperty]
+        private string? name;
+    }
+
     [ObservableRecipient]
     partial class BroadcastingViewModelWithAttribute : ObservableObject
     {
@@ -1100,6 +1191,37 @@ public BroadcastingViewModelWithInheritedAttribute(IMessenger messenger)
         private string? name2;
     }
 
+    [NotifyRecipients]
+    partial class BroadcastingViewModelWithClassLevelAttribute : ObservableRecipient
+    {
+        public BroadcastingViewModelWithClassLevelAttribute(IMessenger messenger)
+            : base(messenger)
+        {
+        }
+
+        [ObservableProperty]
+        private string? name;
+    }
+
+    [ObservableRecipient]
+    [NotifyRecipients]
+    partial class BroadcastingViewModelWithAttributeAndClassLevelAttribute : ObservableObject
+    {
+        [ObservableProperty]
+        private string? name;
+    }
+
+    partial class BroadcastingViewModelWithInheritedAttributeAndClassLevelAttribute : BroadcastingViewModelWithClassLevelAttribute
+    {
+        public BroadcastingViewModelWithInheritedAttributeAndClassLevelAttribute(IMessenger messenger)
+            : base(messenger)
+        {
+        }
+
+        [ObservableProperty]
+        private string? name2;
+    }
+
 #if NET6_0_OR_GREATER
     private partial class NullableRepro : ObservableObject
     {