Add SyntaxTokenExtensions, minor code refactoring

Author: Sergio0694

src/CommunityToolkit.Mvvm.SourceGenerators/CommunityToolkit.Mvvm.SourceGenerators.projitems

@@ -59,6 +59,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)Extensions\SourceProductionContextExtensions.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Extensions\ITypeSymbolExtensions.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Extensions\MemberDeclarationSyntaxExtensions.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)Extensions\SyntaxTokenExtensions.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Extensions\SyntaxNodeExtensions.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Extensions\TypeDeclarationSyntaxExtensions.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Helpers\EquatableArray{T}.cs" />

src/CommunityToolkit.Mvvm.SourceGenerators/ComponentModel/ObservablePropertyGenerator.Execute.cs

@@ -193,7 +193,7 @@ public static bool TryGetInfo(
                 // Only look for attribute lists explicitly targeting the (generated) property. Roslyn will normally emit a
                 // CS0657 warning (invalid target), but that is automatically suppressed by a dedicated diagnostic suppressor
                 // that recognizes uses of this target specifically to support [ObservableProperty].
-                if (attributeList.Target?.Identifier.Kind() is not SyntaxKind.PropertyKeyword)
+                if (attributeList.Target?.Identifier is not SyntaxToken(SyntaxKind.PropertyKeyword))
                 {
                     continue;
                 }

src/CommunityToolkit.Mvvm.SourceGenerators/Extensions/SyntaxTokenExtensions.cs

@@ -0,0 +1,24 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CSharp;
+
+namespace CommunityToolkit.Mvvm.SourceGenerators.Extensions;
+
+/// <summary>
+/// Extension methods for the <see cref="SyntaxToken"/> type.
+/// </summary>
+internal static class SyntaxTokenExtensions
+{
+    /// <summary>
+    /// Deconstructs a <see cref="SyntaxToken"/> into its <see cref="SyntaxKind"/> value.
+    /// </summary>
+    /// <param name="syntaxToken">The input <see cref="SyntaxToken"/> value.</param>
+    /// <param name="syntaxKind">The resulting <see cref="SyntaxKind"/> value for <paramref name="syntaxToken"/>.</param>
+    public static void Deconstruct(this SyntaxToken syntaxToken, out SyntaxKind syntaxKind)
+    {
+        syntaxKind = syntaxToken.Kind();
+    }
+}

src/CommunityToolkit.Mvvm.SourceGenerators/Input/RelayCommandGenerator.Execute.cs

@@ -964,7 +964,7 @@ private static void GatherForwardedAttributes(
                 foreach (AttributeListSyntax attributeList in methodDeclaration.AttributeLists)
                 {
                     // Same as in the [ObservableProperty] generator, except we're also looking for fields here
-                    if (attributeList.Target?.Identifier.Kind() is not (SyntaxKind.PropertyKeyword or SyntaxKind.FieldKeyword))
+                    if (attributeList.Target?.Identifier is not SyntaxToken(SyntaxKind.PropertyKeyword or SyntaxKind.FieldKeyword))
                     {
                         continue;
                     }
@@ -986,7 +986,7 @@ private static void GatherForwardedAttributes(
                         AttributeInfo attributeInfo = AttributeInfo.From(attributeTypeSymbol, semanticModel, attribute.ArgumentList?.Arguments ?? Enumerable.Empty<AttributeArgumentSyntax>(), token);
 
                         // Add the new attribute info to the right builder
-                        if (attributeList.Target?.Identifier.Kind() is SyntaxKind.FieldKeyword)
+                        if (attributeList.Target?.Identifier is SyntaxToken(SyntaxKind.FieldKeyword))
                         {
                             fieldAttributesInfo.Add(attributeInfo);
                         }